Skip to content

Update ConfigurationAsCode category and exception handling#2830

Merged
timja merged 8 commits intojenkinsci:masterfrom
somiljain2006:view-export-yaml-rendering
Apr 14, 2026
Merged

Update ConfigurationAsCode category and exception handling#2830
timja merged 8 commits intojenkinsci:masterfrom
somiljain2006:view-export-yaml-rendering

Conversation

@somiljain2006
Copy link
Copy Markdown
Contributor

@somiljain2006 somiljain2006 commented Apr 13, 2026

This PR updates the Configuration as Code management link and improves related error handling

Changes included:

  • Category Update: Replaced the legacy getCategoryName() string method with the modern getCategory() API
  • Exception Handling: Replaced generic TODO comments in doReplace() with thrown ConfiguratorExceptions.
  • Cleaned up View Export: Removed the hacky dummy ManagementLink object in doViewExport(). The exported YAML is now passed securely as a standard request attribute to viewExport.jelly.
  • Added Debug Logging: Added FINE level logging when skipping non-YAML bundled resources.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test case? That demonstrates a feature that works or fixes the issue.

@somiljain2006 somiljain2006 requested a review from a team as a code owner April 13, 2026 17:50
Comment thread test-harness/src/test/java/io/jenkins/plugins/casc/ConfigurationAsCodeTest.java Outdated
@somiljain2006 somiljain2006 requested a review from timja April 14, 2026 18:33
Comment thread plugin/src/test/java/io/jenkins/plugins/casc/ErrorPageTest.java Outdated
Copy link
Copy Markdown
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I tested on weekly and the breadcrumb is fixed, LTS its got the duplicate issue but I don't think we need to increase the baseline for that.

@timja timja added the feature A PR that adds a feature - used by Release Drafter label Apr 14, 2026
@timja timja enabled auto-merge (squash) April 14, 2026 21:03
@timja timja merged commit a57f83f into jenkinsci:master Apr 14, 2026
17 checks passed
@somiljain2006 somiljain2006 deleted the view-export-yaml-rendering branch April 15, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A PR that adds a feature - used by Release Drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants