Skip to content

Remove outdated TODO about repository-settings issue #107#2821

Merged
timja merged 1 commit intojenkinsci:masterfrom
somiljain2006:Resolving-repository-setting-todo
Apr 9, 2026
Merged

Remove outdated TODO about repository-settings issue #107#2821
timja merged 1 commit intojenkinsci:masterfrom
somiljain2006:Resolving-repository-setting-todo

Conversation

@somiljain2006
Copy link
Copy Markdown
Contributor

@somiljain2006 somiljain2006 commented Apr 9, 2026

The TODO referenced #107, which was closed without implementation. The requested feature (to prevent deletion of labels not defined in settings.yml) was never added. Since repository-settings still enforces exact label sync, removing local label definitions could lead to unintended deletions. The TODO is no longer actionable, so I've removed it while keeping the labels defined locally.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates a feature that works or fixes the issue.

@timja timja added the documentation A PR that adds to documentation - used by Release Drafter label Apr 9, 2026
@timja timja merged commit 600041f into jenkinsci:master Apr 9, 2026
17 checks passed
@somiljain2006 somiljain2006 deleted the Resolving-repository-setting-todo branch April 9, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation A PR that adds to documentation - used by Release Drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants