Add support for disconnectedOnStartup node property with launch prevention#2812
Open
somiljain2006 wants to merge 5 commits intojenkinsci:masterfrom
Open
Add support for disconnectedOnStartup node property with launch prevention#2812somiljain2006 wants to merge 5 commits intojenkinsci:masterfrom
somiljain2006 wants to merge 5 commits intojenkinsci:masterfrom
Conversation
Contributor
Author
|
@timja Can you review this pr? |
Member
|
not sure on this, we try minimise this sort of thing. Since its core though it might be needed. @jetersen any thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1793
Implement the disconnectedOnStartup node property to enforce the offline state and block agent launch
Verified via JenkinsRule tests and manual testing (SSH launcher).
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.