Skip to content

Fix export of list attributes with custom Stapler converters #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
somiljain2006 wants to merge 17 commits into
base: master
Choose a base branch
from
+506 −2
Draft

Fix export of list attributes with custom Stapler converters #2789

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
04d7098
Fix export of list attributes with custom Stapler converters
somiljain2006 Feb 20, 2026
fbd5282
Improve code coverage by addming more tests
somiljain2006 Feb 21, 2026
d170186
Remove unnecessary additions
somiljain2006 Feb 21, 2026
1125720
Added more tests
somiljain2006 Feb 21, 2026
164cfd7
Fixed formatting errors
somiljain2006 Feb 21, 2026
45cc362
Remove unused code
somiljain2006 Feb 22, 2026
1be85e6
Remove unused annotations
somiljain2006 Feb 22, 2026
2b860c0
Remove unreachable code
somiljain2006 Feb 22, 2026
c2ec615
Added brancket in if condition
somiljain2006 Feb 22, 2026
073d56f
Increase code coverage
somiljain2006 Feb 22, 2026
7ac085a
Added more tests
somiljain2006 Feb 22, 2026
d2a0cdf
Added code coverage focused test
somiljain2006 Feb 22, 2026
7873454
Added more tests
somiljain2006 Feb 22, 2026
ddfe528
Added more tests
somiljain2006 Feb 22, 2026
f323bdb
Deleted some duplicacy
somiljain2006 Feb 23, 2026
5eab1ff
Merge branch 'master' into List-converter-fix
somiljain2006 Feb 23, 2026
8c91784
Remove dead codes
somiljain2006 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions plugin/src/main/java/io/jenkins/plugins/casc/impl/configurators/DataBoundConfigurator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import io.jenkins.plugins.casc.impl.attributes.DescribableAttribute;
import io.jenkins.plugins.casc.model.CNode;
import io.jenkins.plugins.casc.model.Mapping;
import java.lang.reflect.Array;
import java.lang.reflect.Constructor;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
Expand Down Expand Up @@ -301,8 +302,40 @@ public CNode describe(T instance, ConfigurationContext context) throws Exception
if (a != null) {
Object value = a.getValue(instance);
if (value != null) {
Object converted = Stapler.CONVERT_UTILS.convert(value, a.getType());
if (converted instanceof Collection || p.getType().isArray() || !a.isMultiple()) {
Class<?> targetType = a.getType();
Object converted;

if (a.isMultiple() && value instanceof Collection) {
List<Object> list = new ArrayList<>();
Copy link
Copy Markdown
Member

@timja timja Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no coverage of this.

Can you please run the coverage locally?

mvnd clean verify jacoco:report -P enable-jacoco

# then
open plugin/target/site/jacoco/index.html

here's a screenshot of the current state:
image

Copy link
Copy Markdown
Contributor Author

@somiljain2006 somiljain2006 Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm working on adding tests to get those exact lines covered, and thanks for sharing that local coverage command that is going to make testing this locally much easier

for (Object o : (Collection<?>) value) {
list.add(Stapler.CONVERT_UTILS.convert(o, targetType));
}
converted = list;
} else if (a.isMultiple() && value.getClass().isArray()) {
List<Object> list = new ArrayList<>();
int len = Array.getLength(value);
for (int j = 0; j < len; j++) {
list.add(Stapler.CONVERT_UTILS.convert(Array.get(value, j), targetType));
}
converted = list;
} else {
converted = Stapler.CONVERT_UTILS.convert(value, targetType);
}

if (p.getType().isArray() && converted instanceof Collection<?> col) {
Class<?> component = p.getType().getComponentType();
Object array = Array.newInstance(component, col.size());
int idx = 0;
for (Object o : col) {
Array.set(array, idx++, o);
}
args[i] = array;

} else if (Set.class.isAssignableFrom(p.getType()) && converted instanceof Collection) {
args[i] = new HashSet<>((Collection<?>) converted);
} else if (converted instanceof Collection
|| (converted != null && converted.getClass().isArray())
|| !a.isMultiple()) {
args[i] = converted;
} else if (Set.class.isAssignableFrom(p.getType())) {
args[i] = Collections.singleton(converted);
Expand Down
Loading
Loading