Adjust for experimental Manage Jenkins UI#2756
Merged
timja merged 13 commits intojenkinsci:masterfrom Jan 28, 2026
Merged
Conversation
Member
|
Before screenshots would be great to add to make easier for comparison |
timja
reviewed
Dec 16, 2025
| </l:hasAdministerOrManage> | ||
| </f:form> | ||
| <j:jelly xmlns:j="jelly:core" xmlns:l="/lib/layout" xmlns:f="/lib/form" xmlns:i="jelly:fmt" xmlns:t="/lib/hudson"> | ||
| <l:settings-subpage permissions="${app.MANAGE_AND_SYSTEM_READ}" header="${null}"> |
Member
There was a problem hiding this comment.
why pass header=null? you can just pass your own header through with a j:set ?
Member
Author
There was a problem hiding this comment.
The dialog wasn't working in the <l:notice /> with a null header, so I moved it inside the subpage.
timja
reviewed
Dec 16, 2025
timja
reviewed
Dec 16, 2025
timja
reviewed
Dec 16, 2025
timja
reviewed
Dec 16, 2025
Member
I'd be surprised if there's much test coverage around this page... |
timja
reviewed
Dec 17, 2025
timja
reviewed
Dec 17, 2025
timja
reviewed
Dec 17, 2025
Member
|
I've tested locally and it looks great. |
timja
approved these changes
Jan 28, 2026
jtnord
reviewed
Feb 1, 2026
| <f:form method="post" action="replace" name="replace"> | ||
| <input type="hidden" name="${h.getCrumbRequestField()}" value="${h.getCrumb(request2)}"/> | ||
| <f:entry title="${%Path or URL}" field="newSource" class="jenkins-form-item--small"> | ||
| <f:textbox checkUrl="checkNewSource" checkDependsOn="newSource"/> |
Member
There was a problem hiding this comment.
@janfaracik most likely the cause of the ATH failure -
https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/master/1872/testReport/junit/plugins/ConfigurationAsCodeTest/latest_linux_jdk25_firefox_split7___loadAndReload/
org.openqa.selenium.NoSuchElementException: Unable to locate By.cssSelector: [path='/newSource'] in http://mvn:35985/configuration-as-code/
at org.jenkinsci.test.acceptance.po.CapybaraPortingLayerImpl.find(CapybaraPortingLayerImpl.java:206)
at org.jenkinsci.test.acceptance.po.Control.resolve(Control.java:58)
at org.jenkinsci.test.acceptance.po.Control.set(Control.java:162)
at org.jenkinsci.test.acceptance.plugins.configuration_as_code.JcascManage.configure(JcascManage.java:46)
at plugins.ConfigurationAsCodeTest.loadAndReload(ConfigurationAsCodeTest.java:46)
Member
There was a problem hiding this comment.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still rough, tests will definitely be broken:
Would be good to get thoughts.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.