docs: update demos with latest changes to EC2 plugin and globalLibraries#2724
Merged
timja merged 14 commits intojenkinsci:masterfrom Oct 17, 2025
Merged
docs: update demos with latest changes to EC2 plugin and globalLibraries#2724timja merged 14 commits intojenkinsci:masterfrom
timja merged 14 commits intojenkinsci:masterfrom
Conversation
timja
reviewed
Oct 11, 2025
akhilsmokie3-ops
approved these changes
Oct 11, 2025
Member
|
The demos are mostly tested see https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/demos/README.adoc You'll need to update the ec2 plugin and git plugin in the integrations pom.xml |
ZeBidule
reviewed
Oct 14, 2025
| ```yaml | ||
| x-ec2_anchor: &ec2_anchor | ||
| associatePublicIp: false | ||
| associateIpStrategy: PRIVATE_IP |
There was a problem hiding this comment.
The correct key is associateIPStrategy and not associateIpStrategy
timja
approved these changes
Oct 14, 2025
Member
timja
left a comment
There was a problem hiding this comment.
I've fixed up the remaining bits, I think this should do it, although I haven't run it locally
timja
reviewed
Oct 17, 2025
timja
reviewed
Oct 17, 2025
timja
reviewed
Oct 17, 2025
timja
reviewed
Oct 17, 2025
timja
reviewed
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update demos with latest changes:
associatePublicIpand addAssociateIpStrategyenum for IP assignment control ec2-plugin#1148Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.