Skip to content

docs: update demos with latest changes to EC2 plugin and globalLibraries#2724

Merged
timja merged 14 commits intojenkinsci:masterfrom
colshine1:master
Oct 17, 2025
Merged

docs: update demos with latest changes to EC2 plugin and globalLibraries#2724
timja merged 14 commits intojenkinsci:masterfrom
colshine1:master

Conversation

@colshine1
Copy link
Copy Markdown
Contributor

update demos with latest changes:

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

Comment thread demos/ec2/README.md Outdated
@timja
Copy link
Copy Markdown
Member

timja commented Oct 12, 2025

The demos are mostly tested see https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/demos/README.adoc

You'll need to update the ec2 plugin and git plugin in the integrations pom.xml

Comment thread demos/ec2/README.md Outdated
```yaml
x-ec2_anchor: &ec2_anchor
associatePublicIp: false
associateIpStrategy: PRIVATE_IP
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct key is associateIPStrategy and not associateIpStrategy

@timja timja added the documentation A PR that adds to documentation - used by Release Drafter label Oct 14, 2025
Copy link
Copy Markdown
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed up the remaining bits, I think this should do it, although I haven't run it locally

Comment thread integrations/pom.xml Outdated
Comment thread pom.xml Outdated
Comment thread integrations/src/test/java/io/jenkins/plugins/casc/EC2CloudTest.java Outdated
Comment thread integrations/src/test/java/io/jenkins/plugins/casc/EC2CloudTest.java Outdated
Comment thread integrations/src/test/java/io/jenkins/plugins/casc/EC2CloudTest.java Outdated
@timja timja merged commit 298d53c into jenkinsci:master Oct 17, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation A PR that adds to documentation - used by Release Drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants