Skip to content

Revert "Allowing empty valued global variables in config file"#2663

Merged
timja merged 1 commit intomasterfrom
revert-2657-empty-vars-exporting
Apr 7, 2025
Merged

Revert "Allowing empty valued global variables in config file"#2663
timja merged 1 commit intomasterfrom
revert-2657-empty-vars-exporting

Conversation

@timja
Copy link
Copy Markdown
Member

@timja timja commented Apr 7, 2025

Reverts #2657

Fixes #2662

@timja timja added the bug label Apr 7, 2025
@timja timja requested a review from a team as a code owner April 7, 2025 07:53
@timja timja enabled auto-merge (squash) April 7, 2025 07:53
@timja timja merged commit 148f87d into master Apr 7, 2025
18 checks passed
@timja timja deleted the revert-2657-empty-vars-exporting branch April 7, 2025 09:18
@jglick
Copy link
Copy Markdown
Member

jglick commented Apr 7, 2025

Whatever broke, should there be a new regression test for it?

@PereBueno
Copy link
Copy Markdown
Contributor

Whatever broke, should there be a new regression test for it?

Now there is 😄 #2665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

globalNodeProperties is processing environment variable reference syntax (${FOO}) as string literal

3 participants