Skip to content

Loumir update preview#51

Open
loumir wants to merge 14 commits intoivoa:mainfrom
loumir:loumir-update_preview
Open

Loumir update preview#51
loumir wants to merge 14 commits intoivoa:mainfrom
loumir:loumir-update_preview

Conversation

@loumir
Copy link
Copy Markdown
Contributor

@loumir loumir commented May 5, 2026

I am trying to fix the workflow.
let's test first that the document is properly generated . then in the next iterations we can fix the other changes proposed in the various commits.

Copy link
Copy Markdown
Collaborator

@bkhelifi bkhelifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @loumir . There are many interesting inputs.
There are also points to discuss on

Comment thread response_table.tex Outdated
Comment thread response_table.tex
Comment on lines +13 to +18
\item curation attributes : \emph{resp\_publisher\_did}, \emph{resp\_\_date}
\item identification of the observation it belongs to : \emph{obs\_id}
\item identification of the ObsCore data products it relates to : \emph{obs\_publisher\_did}
\item access : \emph{resp\_access\_url} and \emph{resp\_access\_format}
\item response spatial coverage
\item response energy coverage
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
\item curation attributes : \emph{resp\_publisher\_did}, \emph{resp\_\_date}
\item identification of the observation it belongs to : \emph{obs\_id}
\item identification of the ObsCore data products it relates to : \emph{obs\_publisher\_did}
\item access : \emph{resp\_access\_url} and \emph{resp\_access\_format}
\item response spatial coverage
\item response energy coverage
\item curation attributes : \emph{resp\_publisher\_did}, \emph{resp\_\_date},
\item identification of the observation it belongs to : \emph{obs\_id},
\item identification of the ObsCore data products it relates to : \emph{obs\_publisher\_did},
\item access : \emph{resp\_access\_url} and \emph{resp\_access\_format},
\item response spatial coverage,
\item response energy coverage,
\item response time coverage.

Comment thread Makefile Outdated
Comment thread HighEnergyObsCoreExt.tex
s\_ref\_energy & \ucd{meta.ref;em.energy;pos} & eV & float & {\footnotesize Energy at which the ObsCore spatial characterisation attributes s\_fov , s\_region, s\_resolution are defined} & NO \\
\hline
{\em em\_ref\_oaa\/} & TBD & deg & double & Off-axis angle ({\em i.e.\/}, the angular separation of the target or source from the telescope optical axis) at which the ObsCore spectral characterization attributes {\em em\_res\_power\/}, {\em em\_resolution\/} are defined & NO \\
em\_ref\_energy & \ucd{meta.ref;em.energy;em} & eV & float & {\footnotesize Energy at which the ObsCore spatial characterisation attributes em\_res\_power, em\_resolution are defined} & NO \\
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
em\_ref\_energy & \ucd{meta.ref;em.energy;em} & eV & float & {\footnotesize Energy at which the ObsCore spatial characterisation attributes em\_res\_power, em\_resolution are defined} & NO \\
em\_ref\_energy & \ucd{meta.ref;phys.energy} & eV & float & {\footnotesize Energy at which the ObsCore spectral characterisation attributes em\_res\_power, em\_resolution are defined} & NO \\

Comment thread VEPforUCD/VEP-UCD-30-stat-error-sup-inf.txt Outdated
Comment thread HighEnergyObsCoreExt.tex
{\centering \bf Column Name} &{\centering \bf UType} &{\centering \bf Unit} &{\centering \bf Type} &{\centering \bf Description} &{\centering \bf MAN}\\
\hline
{\em ev\_xel\/} & TBD & unitless & integer & Number of events in an event list & NO \\
\begin{longtable}{ | m{2.5cm} | m{4em} | m{3em} | m{3em} | m{6cm} | m{2.3em} |}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fit a page width. To be changed

Comment thread HighEnergyObsCoreExt.tex
ev\_xel & \ucd{meta.number;obs.event} & unitless & int & {\footnotesize Number of events in an event\_list }& NO \\
\hline
{\em s\_ref\_oaa\/} & TBD & deg & double & Off-axis angle ({\em i.e.\/}, the angular separation of the target or source from the telescope optical axis) at which the ObsCore spatial characterization attributes {\em s\_fov\/}, {\em s\_region\/}, {\em s\_resolution\/} are defined & NO \\
s\_ref\_energy & \ucd{meta.ref;em.energy;pos} & eV & float & {\footnotesize Energy at which the ObsCore spatial characterisation attributes s\_fov , s\_region, s\_resolution are defined} & NO \\
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
s\_ref\_energy & \ucd{meta.ref;em.energy;pos} & eV & float & {\footnotesize Energy at which the ObsCore spatial characterisation attributes s\_fov , s\_region, s\_resolution are defined} & NO \\
s\_ref\_energy & \ucd{meta.ref;phys.energy;pos} & eV & float & {\footnotesize Energy at which the ObsCore spatial characterisation attributes s\_fov , s\_region, s\_resolution are defined} & NO \\

Comment thread HighEnergyObsCoreExt.tex
s\_ref\_oaa & \ucd{pos.posAng;instr.offset;pos} & deg & float & {\footnotesize Off-axis angle (i.e., the angular separation of the target or source from the telescope optical axis) at which the ObsCore spatial characterisation attributes s\_fov , s\_region, s\_resolution are defined} & NO \\
\hline
{\em energy\_min\/} & TBD & eV & double & Energy associated to the ObsCore attribute {\em em\_max\/}, describing the minimum energy of the dataset & NO \\
em\_ref\_oaa & \ucd{pos.posAng;instr.offset;em} & deg & float & {\footnotesize Off-axis angle (i.e., the angular separation of the target or source from the telescope optical axis) at which the ObsCore spectral characterisation attributes em\_res\_power, em\_resolution are defined} & NO \\
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"pos.posAng;instr.offset;em" or "pos.posAng;instr.offset", because events are not necessary photons...

Comment thread HighEnergyObsCoreExt.tex
t\_intervals & \ucd{?? }& unitless & TMOC & {\footnotesize List of observation intervals or stable/good time intervals describing the exact observation time coverage} & NO \\
\hline
{\em obs\_mode\/} & TBD & unitless & string & Observation mode of an observation & NO \\
energy\_min & \ucd{em.energy;stat.min} & float & eV & {\footnotesize Energy associated to the Obscore attribute em\_max, describing the minimal energy of the dataset} & NO \\
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
energy\_min & \ucd{em.energy;stat.min} & float & eV & {\footnotesize Energy associated to the Obscore attribute em\_max, describing the minimal energy of the dataset} & NO \\
energy\_min & \ucd{phys.energy;stat.min} & float & eV & {\footnotesize Energy associated to the Obscore attribute em\_max, describing the minimal energy of the dataset} & NO \\

Comment thread response_table.tex
@@ -0,0 +1,57 @@

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tex file is not used in the building of the document. What is it used for?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this table summarizes the properties of a data set identified for a response data product. This gathers the minimal set of attributes necessary to select a response file ( for example a PSF file within a set of response file) .
the main selection criteria is based on the ids either of the observation , or of the event-list .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants