IVF: add IDFilter support and set_intra_query_threads in cpp runtime#322
Open
IVF: add IDFilter support and set_intra_query_threads in cpp runtime#322
set_intra_query_threads in cpp runtime#322Conversation
…tch heuristic - bindings/cpp ivf_index/dynamic_ivf_index: SearchParams gains filter_stop and filter_estimate_batch; search() accepts IDFilter*; filter loop mirrors PR #309 adaptive batch heuristic. - Manager classes expose get/set_num_intra_query_threads. - IVFIndex / DynamicIVFIndex: set_threadpool() also rebuilds intra-query thread pools; add set_num_intra_query_threads(). - Tests: 4 new cases mirroring Vamana PR#309 (restrictive filter + filter_stop early-exit, static & dynamic).
- Use std::span for batch_iterator (public API signature) - Remove calls to set/get_num_intra_query_threads which don't exist in v0.3.0 - Store intra_query_threads locally; value used at construction time
- Update to nightly build (2026-05-06) which includes IVF intra-query threading API - Restore calls to set/get_num_intra_query_threads on impl_ - Remove fallback logic since nightly build has these methods
ethanglaser
reviewed
May 7, 2026
ethanglaser
reviewed
May 7, 2026
| } | ||
|
|
||
| ///// Intra-query (cluster-level) parallelism | ||
| [[nodiscard]] size_t get_num_intra_query_threads() const override { |
Member
There was a problem hiding this comment.
Just curious on why [[nodiscard]] is used here and not elsewhere - I am not particularly familiar with what nodiscard does
| std::tie(sampled, sample_hits) = sample_filter_hits( | ||
| *filter, | ||
| max_batch_size, | ||
| [this](size_t id) { return impl_->has_id(id); }, |
Member
There was a problem hiding this comment.
Looks like this is nearly identical diff to the non-dynamic except this line - why is it different here?
Side note - are these classes something that we should look into having inheritance for?
Comment on lines
+260
to
+262
| intra_query_threads_ = intra_query_threads; | ||
| // Note: impl_ uses the value set at construction time, | ||
| // changing it here requires rebuilding/reloading the index |
Member
There was a problem hiding this comment.
This seems not ideal - should it call impl_->set_num_intra_query_threads(intra_query_threads) ?
ethanglaser
reviewed
May 7, 2026
Member
There was a problem hiding this comment.
Worth testing case where filter_estimate_batch=false?
And what about comparison of results for runs with different number of intra_query_threads?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings two FAISS-required runtime features to the IVF C++ bindings:
IDFilter-based search to supportSearchParameters::selselectors inIndexSVSIVF.The ability to change the intra-query thread count after
train()/load()(mirrors Vamana).