-
Notifications
You must be signed in to change notification settings - Fork 961
chore: Use tf plugin docs #3380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,8 +1,8 @@ | ||||||||
| name: Acceptance Tests (github.com) | ||||||||
|
|
||||||||
| on: | ||||||||
| workflow_dispatch: | ||||||||
| # push: | ||||||||
| workflow_dispatch: # push: | ||||||||
|
|
||||||||
| # branches: | ||||||||
| # - main | ||||||||
| # - release-v* | ||||||||
|
|
@@ -25,7 +25,9 @@ permissions: read-all | |||||||
| jobs: | ||||||||
| test: | ||||||||
| name: Test ${{ matrix.mode }} | ||||||||
| if: (github.event_name != 'pull_request' && github.event_name != 'pull_request_target') || contains(github.event.pull_request.labels.*.name, 'acctest') | ||||||||
| if: (github.event_name != 'pull_request' && github.event_name != | ||||||||
| 'pull_request_target') || | ||||||||
| contains(github.event.pull_request.labels.*.name, 'acctest') | ||||||||
| runs-on: ubuntu-latest | ||||||||
| permissions: | ||||||||
| contents: read | ||||||||
|
|
@@ -34,7 +36,7 @@ jobs: | |||||||
| deployment: false | ||||||||
| strategy: | ||||||||
| matrix: | ||||||||
| mode: [anonymous, individual, organization] # team, enterprise | ||||||||
| mode: [ anonymous, individual, organization ] # team, enterprise | ||||||||
| fail-fast: true | ||||||||
| max-parallel: 1 | ||||||||
| defaults: | ||||||||
|
|
@@ -47,7 +49,8 @@ jobs: | |||||||
| - name: Check secrets | ||||||||
| if: github.event_name == 'pull_request_target' | ||||||||
| env: | ||||||||
| INPUT_ALLOWED_SECRETS: ${{ vars.DOTCOM_ACCEPTANCE_TESTS_ALLOWED_SECRETS || 'GH_TEST_TOKEN' }} | ||||||||
| INPUT_ALLOWED_SECRETS: ${{ vars.DOTCOM_ACCEPTANCE_TESTS_ALLOWED_SECRETS || | ||||||||
| 'GH_TEST_TOKEN' }} | ||||||||
| INPUT_SECRETS: ${{ toJSON(secrets) }} | ||||||||
| run: | | ||||||||
| set -eou pipefail | ||||||||
|
|
@@ -74,7 +77,7 @@ jobs: | |||||||
| echo "token=${GH_TEST_TOKEN}" >> "${GITHUB_OUTPUT}" | ||||||||
|
|
||||||||
| - name: Set-up Go | ||||||||
| uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5 # v6.2.0 | ||||||||
| uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0 | ||||||||
| with: | ||||||||
| go-version-file: go.mod | ||||||||
| cache: true | ||||||||
|
|
@@ -104,7 +107,8 @@ jobs: | |||||||
| TF_LOG: WARN | ||||||||
| GITHUB_TOKEN: ${{ steps.credentials.outputs.token }} | ||||||||
| GITHUB_BASE_URL: https://api.github.com/ | ||||||||
| GITHUB_OWNER: ${{ (matrix.mode == 'individual' && vars.GH_TEST_LOGIN) || (matrix.mode == 'organization' && vars.GH_TEST_ORG_NAME) || '' }} | ||||||||
| GITHUB_OWNER: ${{ (matrix.mode == 'individual' && vars.GH_TEST_LOGIN) || | ||||||||
| (matrix.mode == 'organization' && vars.GH_TEST_ORG_NAME) || '' }} | ||||||||
|
Comment on lines
+110
to
+111
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can be made slightly easier to read with
Suggested change
|
||||||||
| GITHUB_USERNAME: ${{ vars.GH_TEST_LOGIN }} | ||||||||
| GITHUB_ENTERPRISE_SLUG: ${{ vars.GH_TEST_ENTERPRISE_SLUG }} | ||||||||
| GH_TEST_AUTH_MODE: ${{ matrix.mode }} | ||||||||
|
|
||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ jobs: | |
| fetch-depth: 0 | ||
|
|
||
| - name: Set-up Go | ||
| uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5 # v6.2.0 | ||
| uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0 | ||
| with: | ||
| go-version-file: go.mod | ||
| cache: true | ||
|
|
@@ -67,4 +67,5 @@ jobs: | |
| - name: Attest artifacts | ||
| uses: actions/attest-build-provenance@96278af6caaf10aea03fd8d33a09a777ca52d62f # v3.2.0 | ||
| with: | ||
| subject-checksums: ./dist/${{ github.event.repository.name }}_${{ fromJSON(steps.goreleaser.outputs.metadata).version }}_SHA256SUMS | ||
| subject-checksums: ./dist/${{ github.event.repository.name }}_${{ | ||
| fromJSON(steps.goreleaser.outputs.metadata).version }}_SHA256SUMS | ||
|
Comment on lines
+70
to
+71
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: Will this line break work? |
||
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,18 @@ | ||||||
| [global] | ||||||
| disable = ["MD013", "MD028"] | ||||||
|
|
||||||
| [per-file-ignores] | ||||||
| ".github/pull_request_template.md" = ["MD041"] | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: I would Ignore MD009 as well in the PR template as the empty lines are meaningful in there
Suggested change
|
||||||
| "docs/**/*.md" = ["MD059"] | ||||||
|
|
||||||
| [MD004] | ||||||
| style = "dash" | ||||||
|
|
||||||
| [MD024] | ||||||
| siblings-only = true | ||||||
|
|
||||||
| [MD033] | ||||||
| allowed-elements = ["a", "br", "details", "img", "summary", "sub", "sup"] | ||||||
|
|
||||||
| [MD052] | ||||||
| shortcut-syntax = true | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this just be removed?