fix: avoid 422 when enterprise policy controls org fork setting#3360
Open
andrewesweet wants to merge 1 commit intointegrations:mainfrom
Open
fix: avoid 422 when enterprise policy controls org fork setting#3360andrewesweet wants to merge 1 commit intointegrations:mainfrom
andrewesweet wants to merge 1 commit intointegrations:mainfrom
Conversation
Remove Default: false from members_can_fork_private_repositories schema to prevent the field from being sent to the API when not explicitly set by the user. When an enterprise-level policy locks this setting, sending any value causes a 422 validation error. Without a default, the field is only included in API calls when the user explicitly configures it, matching the behavior of members_can_create_internal_repositories (enterprise-only field). Fixes integrations#2689 Relates to integrations#1333 Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2689
Relates to #1333
Before the change?
members_can_fork_private_repositorieshasDefault: falsein the schema, causing the field to always be sent to the GitHub API even when not explicitly set by the user.After the change?
Default: falsefrom the schema so the field is only included in API calls when explicitly configured by the user.members_can_create_internal_repositories(enterprise-only field with no default).Users who never set this field see no behavioral change — the API default is
falseand the Read function still populates state from the API response.Pull request checklist
Does this introduce a breaking change?