[MAINT] Upgrade golangci-lint v2.10 & go to 1.26#3244
Merged
stevehipwell merged 11 commits intointegrations:mainfrom Mar 15, 2026
Merged
[MAINT] Upgrade golangci-lint v2.10 & go to 1.26#3244stevehipwell merged 11 commits intointegrations:mainfrom
golangci-lint v2.10 & go to 1.26#3244stevehipwell merged 11 commits intointegrations:mainfrom
Conversation
We don't use it and that version is deprecated Signed-off-by: Timo Sand <[email protected]>
Signed-off-by: Timo Sand <[email protected]>
Signed-off-by: Timo Sand <[email protected]>
Signed-off-by: Timo Sand <[email protected]>
Signed-off-by: Timo Sand <[email protected]>
Since `make build` calls `make lintcheck` Signed-off-by: Timo Sand <[email protected]>
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
stevehipwell
added
the
Type: Maintenance
Signed-off-by: Timo Sand <[email protected]>
Collaborator
Author
|
@stevehipwell For CI to pass I needed to update |
5 tasks
Collaborator
|
Do we want to go to |
Collaborator
Author
Works for me, I'll push it |
Signed-off-by: Timo Sand <[email protected]>
Signed-off-by: Timo Sand <[email protected]>
deiga
changed the title
golangci-lint v2.10golangci-lint v2.10 & go to 1.26
robert-crandall
previously approved these changes
Mar 13, 2026
deiga
dismissed stale reviews from robert-crandall and stevehipwell
via
4a1e6da
austenstone
pushed a commit
to austenstone/terraform-provider-github
that referenced
this pull request
Mar 20, 2026
* Remove `misspell` We don't use it and that version is deprecated Signed-off-by: Timo Sand <[email protected]> * Stop linter failing if there are other linter processes running Signed-off-by: Timo Sand <[email protected]> * Upgrade golangci-lint to v2.10.1 Signed-off-by: Timo Sand <[email protected]> * Fix linter warnings Signed-off-by: Timo Sand <[email protected]> * Remove mentions of `website-lint` Signed-off-by: Timo Sand <[email protected]> * Remove unnecessary `make lintcheck` in `ci.yaml` Since `make build` calls `make lintcheck` Signed-off-by: Timo Sand <[email protected]> * Upgrade to go 1.25 Signed-off-by: Timo Sand <[email protected]> * Update `go` to v1.26 Signed-off-by: Timo Sand <[email protected]> * Run `go fix` and remove unused funcs Signed-off-by: Timo Sand <[email protected]> * Update Terraform version requirement in README * Update Terraform version requirement in README --------- Signed-off-by: Timo Sand <[email protected]>
JiayangZhou
pushed a commit
to JiayangZhou/terraform-provider-github
that referenced
this pull request
Apr 16, 2026
* Remove `misspell` We don't use it and that version is deprecated Signed-off-by: Timo Sand <[email protected]> * Stop linter failing if there are other linter processes running Signed-off-by: Timo Sand <[email protected]> * Upgrade golangci-lint to v2.10.1 Signed-off-by: Timo Sand <[email protected]> * Fix linter warnings Signed-off-by: Timo Sand <[email protected]> * Remove mentions of `website-lint` Signed-off-by: Timo Sand <[email protected]> * Remove unnecessary `make lintcheck` in `ci.yaml` Since `make build` calls `make lintcheck` Signed-off-by: Timo Sand <[email protected]> * Upgrade to go 1.25 Signed-off-by: Timo Sand <[email protected]> * Update `go` to v1.26 Signed-off-by: Timo Sand <[email protected]> * Run `go fix` and remove unused funcs Signed-off-by: Timo Sand <[email protected]> * Update Terraform version requirement in README * Update Terraform version requirement in README --------- Signed-off-by: Timo Sand <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the change?
website-lintmaketarget as it's not necessarymisspelltool,golangci-linthas it's internalmisspellPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!