feat: Refactor repository collaborators#3233
Merged
stevehipwell merged 1 commit intointegrations:mainfrom Mar 18, 2026
Merged
Conversation
stevehipwell
added
Type: Bug
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
1 task
stevehipwell
force-pushed
the
refactor-repo-collaborators
branch
2 times, most recently
from
55043eb to
4be7e25
Compare
deiga
reviewed
Feb 27, 2026
Collaborator
deiga
left a comment
deiga
left a comment
There was a problem hiding this comment.
Partial review. Loving the direction here!
stevehipwell
force-pushed
the
refactor-repo-collaborators
branch
from
4be7e25 to
42a9206
Compare
stevehipwell
force-pushed
the
refactor-repo-collaborators
branch
from
42a9206 to
9e51b07
Compare
Collaborator
Author
|
@robert-crandall please could you review this PR? |
robert-crandall
previously approved these changes
Mar 17, 2026
robert-crandall
left a comment
robert-crandall
left a comment
There was a problem hiding this comment.
Overall this looks good. I left some questions double checking intent.
Signed-off-by: Steve Hipwell <[email protected]>
stevehipwell
force-pushed
the
refactor-repo-collaborators
branch
from
9e51b07 to
cce7ad0
Compare
Collaborator
Author
|
@robert-crandall this should be good for a re-review. |
robert-crandall
approved these changes
Mar 18, 2026
1 task
JiayangZhou
pushed a commit
to JiayangZhou/terraform-provider-github
that referenced
this pull request
Apr 16, 2026
Signed-off-by: Steve Hipwell <[email protected]>
1 task
5 tasks
deiga
pushed a commit
that referenced
this pull request
Apr 27, 2026
When the invitee of `github_repository_collaborators` is an organization
member who is not yet a direct collaborator, GitHub's REST API returns
`204 No Content` from `PUT /repos/{owner}/{repo}/collaborators/{username}`
(the user is promoted to direct collaborator immediately, no invitation is
issued). The Go client surfaces this as `inv == nil, err == nil`.
Since #3233 the create/update path in `updateUserCollaboratorsAndInvites`
unconditionally dereferences `inv.ID`, causing a nil pointer panic for
any configuration that adds an org member as a direct collaborator for
the first time.
Guard the invitation-tracking branch on `inv != nil`. On the 204 path
there is no invitation to record; the user is a direct collaborator
already and will be picked up by the next `listUserCollaborators` call.
Signed-off-by: bofus10 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2874
Before the change?
github_repository_collaboratorserrored if the repo was renamedgithub_repository_collaboratorsprefered team ID and made extra calls if slug was usedgithub_repository_collaboratorsused unnecessary API calls to re-readAfter the change?
github_repository_collaboratorssupports the repository being renamedgithub_repository_collaboratorsuses the minimum number of API callsPull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!