Skip to content

chore: Fix repo allow forking #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevehipwell merged 1 commit into from
Jan 20, 2026
Merged

chore: Fix repo allow forking #3094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions github/resource_github_repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,9 +634,10 @@ func resourceGithubRepositoryObject(d *schema.ResourceData) *github.Repository {
}

// only configure allow forking if repository is not public
allowForking, ok := d.Get("allow_forking").(bool)
if ok && visibility != "public" {
repository.AllowForking = github.Ptr(allowForking)
if allowForking, ok := d.GetOk("allow_forking"); ok && visibility != "public" {
if val, ok := allowForking.(bool); ok {
repository.AllowForking = github.Ptr(val)
}
}

return repository
Expand Down
29 changes: 28 additions & 1 deletion github/resource_github_repository_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ func TestAccGithubRepository(t *testing.T) {

t.Run("create_private_with_forking", func(t *testing.T) {
randomID := acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum)
repoName := fmt.Sprintf("%svisibility-%s", testResourcePrefix, randomID)
repoName := fmt.Sprintf("%s%s", testResourcePrefix, randomID)

config := fmt.Sprintf(`
resource "github_repository" "test" {
Expand All @@ -597,6 +597,33 @@ func TestAccGithubRepository(t *testing.T) {
})
})

t.Run("create_private_with_forking_unset", func(t *testing.T) {
randomID := acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum)
repoName := fmt.Sprintf("%s%s", testResourcePrefix, randomID)

config := fmt.Sprintf(`
resource "github_repository" "test" {
name = "%s"
description = "A private repository with forking disabled"
visibility = "private"
}
`, repoName)

resource.Test(t, resource.TestCase{
PreCheck: func() { skipUnlessHasOrgs(t) },
ProviderFactories: providerFactories,
Steps: []resource.TestStep{
{
Config: config,
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("github_repository.test", "visibility", "private"),
resource.TestCheckResourceAttr("github_repository.test", "allow_forking", "false"),
),
},
},
})
})

t.Run("configures vulnerability alerts for a private repository", func(t *testing.T) {
randomID := acctest.RandStringFromCharSet(5, acctest.CharSetAlphaNum)
repoName := fmt.Sprintf("%sprv-vuln-%s", testResourcePrefix, randomID)
Expand Down