[BUG] Repository creation as archived would fail

[deiga]

---

Before the change?

• Creating a new github_repository resource with archived = true and visibility = "private" would fail with 403
• Docs stated that unarchiving a repository via API wasn't supported

After the change?

• Creating a new github_repository resource with archived = true will "stop" execution in Create to only set archived on the repo.
• Docs updated to show that unarchiving is supported

Pull request checklist

• Schema migrations have been created if needed (example)
• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes
• No

---

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[stevehipwell]

@deiga could we not just add a diff check function and disable the creation of archived repositories full stop? We could re-visit the functionality once the repository resource has been refactored.

On a separate note, the repository resource really needs to be refactored to avoid the calling of create -> update -> read or update -> read.

[deiga]

@deiga could we not just add a diff check function and disable the creation of archived repositories full stop? We could re-visit the functionality once the repository resource has been refactored.

On a separate note, the repository resource really needs to be refactored to avoid the calling of create -> update -> read or update -> read.

Yes please to the latter.

Fair point to the former. I'll need to revisit this PR as my solution probably didn't consider "what should we allow"

[stevehipwell]

@deiga do you already have an issue tracking the refactoring work?

[deiga]

@deiga do you already have an issue tracking the refactoring work?

@stevehipwell Not for the whole repo changes, just the vulnerability alerts

[stevehipwell]

@deiga FYI #3133