[BUG] Fix resource_github_repository_environment_deployment_policy import

[deiga]

Resolves #3076
Resolves #2012

---

Before the change?

• Importing a resource_github_repository_environment_deployment_policy would fail due to missing setters of fields

After the change?

• Importing a resource_github_repository_environment_deployment_policy sets all correct fields

Pull request checklist

• Schema migrations have been created if needed (example)
• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes
• No

---

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[stevehipwell]

@deiga it looks like I've also fixed this independently in #3079. Although I don't think your current implementation will actually work as URL path escaping doesn't replace :. Would you mind taking a look at my PR to see if I missed anything that you've done? I know I haven't done the logs or contexts as I was focused on just fixing the environment name in ID escaping logic.

[deiga]

@deiga it looks like I've also fixed this independently in #3079. Although I don't think your current implementation will actually work as URL path escaping doesn't replace :. Would you mind taking a look at my PR to see if I missed anything that you've done? I know I haven't done the logs or contexts as I was focused on just fixing the environment name in ID escaping logic.

@stevehipwell One thing you are missing, is the actual fix for the import behaviour. You added a test, but it ignores the problems in the import 😬

[stevehipwell]

@stevehipwell One thing you are missing, is the actual fix for the import behaviour. You added a test, but it ignores the problems in the import 😬

@deiga yeah thanks for spotting that. It wasn't pushed up as I had issues with the testing and stashed a load of code while I attempted to fix it. I've pushed it all up now, and for good measure I've updated the resources to the context pattern.