-
Notifications
You must be signed in to change notification settings - Fork 961
fix: missing error returns #2962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8d7cf68
fix env secrets
nickfloyd 459f14c
fixes env vars
nickfloyd 407299b
fixes default branch
nickfloyd 2759ce7
fixes issues
nickfloyd 2e78d00
fixes membership
nickfloyd 9d84284
fixes org webhooks
nickfloyd 46cfac3
fixes org webhook
nickfloyd c7ae539
fixes repo collab, deply key, policy, and project
nickfloyd a6f70c8
fix the remaining batch of resources
nickfloyd cf1ecf9
fixes the final batch of resources
nickfloyd b9c72ca
Removes workflow
nickfloyd 6691dd7
Merge branch 'main' into 2957-fix-missing-error-returns
nickfloyd 15b8625
Removes all redundant returns
nickfloyd 67001eb
Merge branch '2957-fix-missing-error-returns' of github.com:integrati…
nickfloyd 50f95cd
Updates the logic to remove duplicate contionals and simplify
nickfloyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -97,6 +97,7 @@ func resourceGithubUserSshKeyRead(d *schema.ResourceData, meta any) error { | |
| return nil | ||
| } | ||
| } | ||
| return err | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the only one that doesn't return a redundant error on this PR, I think. But I would still remove the |
||
| } | ||
|
|
||
| if err = d.Set("etag", resp.Header.Get("ETag")); err != nil { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: it looks like the else might be redundant here or are there legitimate use-case where it's fine to swallow
err?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is. When create fails but update succeeds.