feat/fix: Add missing do_not_enforce_on_create parameter to required rules#2659
Closed
oscarbc96 wants to merge 1 commit intointegrations:mainfrom
Closed
feat/fix: Add missing do_not_enforce_on_create parameter to required rules#2659oscarbc96 wants to merge 1 commit intointegrations:mainfrom
oscarbc96 wants to merge 1 commit intointegrations:mainfrom
Conversation
bateller
approved these changes
May 15, 2025
|
Hello, |
1 task
Contributor
|
+1 I just ran into this issue as well |
Collaborator
|
Duplicate of #2488 and resolved by it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #ISSUE_NUMBER
Discoveted while implementing: #2658
Before the change?
The do_not_enforce_on_create parameter was not implemented for the required_status_checks and required_workflows blocks in either the github_organization_ruleset or github_repository_ruleset resources. Although this option was documented in the github_repository_ruleset resource (reference), it was not actually supported by the provider implementation.
Tests are already implemented:
terraform-provider-github/github/resource_github_repository_ruleset_test.go
Line 84 in 6008909
After the change?
This PR implements support for the do_not_enforce_on_create parameter in:
for the github_organization_ruleset and github_repository_ruleset resource. It also ensures that the documentation reflects this capability, aligning the implementation with the existing documentation.
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!