feat: Adding github_enterprise_ip_allow_list_entry resource by ErikElkins · Pull Request #2649 · integrations/terraform-provider-github

ErikElkins · 2025-05-02T14:08:29Z

Resolves #2648

Before the change?

None

After the change?

Adding the github_enterprise_ip_allow_list_entry resource.

Pull request checklist

Tests for the changes have been added (for bug fixes / features)
Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

Yes
No

nickfloyd · 2026-01-13T16:51:41Z

@ErikElkins Apologies for the delay on getting to this PR. Would you be willing to fix the lint issue? Thank you!

stevehipwell

Is there a REST API for this functionality?

ErikElkins · 2026-01-13T20:15:44Z

Yep! Let me jump in here.

Co-authored-by: Steve Hipwell <[email protected]>

ErikElkins · 2026-01-13T20:32:10Z

Oh, i see the other PR. Should we just close this? EDIT: NEVERMIND

ErikElkins · 2026-01-13T20:36:33Z

Is there a REST API for this functionality?

Doesn't look like they've added it since I opened the PR.

gateixeira

hi @ErikElkins 👋

I was updating your PR to have the lint fixed and realized that the acceptance tests seem to also not pass. Can you please update the PR with the following? Feel free to validate on your end.

Co-authored-by: gateixeira <[email protected]>

gateixeira

@ErikElkins thanks for the changes!

stevehipwell · 2026-02-24T18:04:22Z

@deiga are you happy with this now? If so could you please approve (or clear your requested changes)?

deiga · 2026-03-24T11:38:13Z

@ErikElkins Would you be available to rebase and test this again? :)

ErikElkins · 2026-03-24T12:46:39Z

@ErikElkins Would you be available to rebase and test this again? :)

Merged and tested, looks good!

stevehipwell

LGTM

stevehipwell · 2026-04-01T15:56:27Z

@robert-crandall could you please review/approve this?

robert-crandall

This PR looks good. It looks like it's failing CI due to lint errors. Once those are fixed, this is good to go.

ErikElkins · 2026-04-02T19:25:26Z

This PR looks good. It looks like it's failing CI due to lint errors. Once those are fixed, this is good to go.

Done!

deiga · 2026-04-02T20:45:40Z

@stevehipwell @robert-crandall please review again ☺️

LornaJoyce · 2026-04-13T10:18:37Z

Hello, Could this get reviewed please?

deiga · 2026-04-13T18:42:09Z

@ErikElkins could you please rebase, so that @stevehipwell can do final review?

ErikElkins · 2026-04-13T18:43:35Z

@ErikElkins could you please rebase, so that @stevehipwell can do final review?

Done!

stevehipwell

LGTM

ErikElkins · 2026-04-13T19:46:08Z

Thanks everyone!

…ions#2649) * Adding github_enterprise_ip_allow_list_entry resource * Update github/resource_github_enterprise_ip_allow_list_entry.go Co-authored-by: Steve Hipwell <[email protected]> * Update github/resource_github_enterprise_ip_allow_list_entry.go Co-authored-by: Steve Hipwell <[email protected]> * Update github/resource_github_enterprise_ip_allow_list_entry.go Co-authored-by: gateixeira <[email protected]> * Update github/resource_github_enterprise_ip_allow_list_entry_test.go Co-authored-by: gateixeira <[email protected]> * Update github/resource_github_enterprise_ip_allow_list_entry_test.go Co-authored-by: gateixeira <[email protected]> * Code review fixes * Fixes from code review * Fixing code review comments * Update resource_github_enterprise_ip_allow_list_entry.go Co-authored-by: Timo Sand <[email protected]> * Update resource_github_enterprise_ip_allow_list_entry.go Co-authored-by: Timo Sand <[email protected]> * Update github/resource_github_enterprise_ip_allow_list_entry_test.go Co-authored-by: Steve Hipwell <[email protected]> * Update github/resource_github_enterprise_ip_allow_list_entry.go Co-authored-by: Steve Hipwell <[email protected]> * Code review changes * Fixing config in test * Flattening update test * Adding error handling * Simplifying import function * Fix docs * Fixing code review changes * Fixing lint * Adding error handling for missing global ID * Removing two old functions * Fixing lint --------- Co-authored-by: Nick Floyd <[email protected]> Co-authored-by: Steve Hipwell <[email protected]> Co-authored-by: gateixeira <[email protected]> Co-authored-by: Timo Sand <[email protected]>

Adding github_enterprise_ip_allow_list_entry resource

943df18

octokitbot added this to 🧰 Octokit Active May 2, 2025

github-project-automation Bot moved this to 🆕 Triage in 🧰 Octokit Active May 2, 2025

nickfloyd moved this from 🆕 Triage to 👀 In review in 🧰 Octokit Active Jun 3, 2025

Merge branch 'main' into feat/enterprise-ip-allow-list

eb02154

ErikElkins changed the title ~~Adding github_enterprise_ip_allow_list_entry resource~~ feat: Adding github_enterprise_ip_allow_list_entry resource Oct 25, 2025

deiga mentioned this pull request Nov 4, 2025

[FEAT]: Additional Enterprise Settings support #2851

Open

1 task

Merge branch 'main' into feat/enterprise-ip-allow-list

935e689

github-actions Bot added the Type: Feature New feature or request label Jan 13, 2026

nickfloyd previously approved these changes Jan 13, 2026

View reviewed changes

nickfloyd added this to the v6.10.0 Release milestone Jan 13, 2026

stevehipwell requested changes Jan 13, 2026

View reviewed changes

Comment thread github/resource_github_enterprise_ip_allow_list_entry.go Outdated

Comment thread github/resource_github_enterprise_ip_allow_list_entry.go Outdated

Comment thread github/resource_github_enterprise_ip_allow_list_entry.go Outdated

github-project-automation Bot moved this from 👀 In review to 🏗 In progress in 🧰 Octokit Active Jan 13, 2026

stevehipwell modified the milestones: v6.10.0 Release, v6.11.0 Release Jan 13, 2026

gateixeira mentioned this pull request Jan 13, 2026

feat: Adding github_enterprise_ip_allow_list_entry resource #3078

Closed

4 tasks

Update github/resource_github_enterprise_ip_allow_list_entry.go

83a0055

Co-authored-by: Steve Hipwell <[email protected]>

ErikElkins dismissed nickfloyd’s stale review via 83a0055 January 13, 2026 20:29

Update github/resource_github_enterprise_ip_allow_list_entry.go

c3735ac

Co-authored-by: Steve Hipwell <[email protected]>

Merge branch 'main' into feat/enterprise-ip-allow-list

e1b06a2

gateixeira suggested changes Jan 13, 2026

View reviewed changes

ErikElkins and others added 3 commits January 13, 2026 14:52

Update github/resource_github_enterprise_ip_allow_list_entry.go

833f3f1

Co-authored-by: gateixeira <[email protected]>

Update github/resource_github_enterprise_ip_allow_list_entry_test.go

60c686b

Co-authored-by: gateixeira <[email protected]>

Update github/resource_github_enterprise_ip_allow_list_entry_test.go

f667dcc

Co-authored-by: gateixeira <[email protected]>

gateixeira approved these changes Jan 13, 2026

View reviewed changes

Code review fixes

06b2e43

deiga requested changes Feb 24, 2026

View reviewed changes

Comment thread github/resource_github_enterprise_ip_allow_list_entry.go

Comment thread github/resource_github_enterprise_ip_allow_list_entry.go

Adding error handling for missing global ID

c5e2e12

ErikElkins dismissed stevehipwell’s stale review via c5e2e12 February 24, 2026 21:14

deiga approved these changes Feb 27, 2026

View reviewed changes

deiga requested a review from stevehipwell March 5, 2026 22:50

ErikElkins added 2 commits March 24, 2026 07:41

Merge branch 'main' into feat/enterprise-ip-allow-list

43a86af

Removing two old functions

1c87cc4

stevehipwell previously approved these changes Apr 1, 2026

View reviewed changes

robert-crandall previously approved these changes Apr 1, 2026

View reviewed changes

Fixing lint

1a2c79e

ErikElkins dismissed stale reviews from robert-crandall and stevehipwell via 1a2c79e April 2, 2026 19:16

robert-crandall approved these changes Apr 13, 2026

View reviewed changes

Merge branch 'main' into feat/enterprise-ip-allow-list

f1dece8

stevehipwell approved these changes Apr 13, 2026

View reviewed changes

stevehipwell enabled auto-merge (squash) April 13, 2026 19:08

stevehipwell merged commit 866a673 into integrations:main Apr 13, 2026
10 of 13 checks passed

github-project-automation Bot moved this from 🏗 In progress to ✅ Done in 🧰 Octokit Active Apr 13, 2026

ErikElkins deleted the feat/enterprise-ip-allow-list branch April 13, 2026 19:45

Conversation

ErikElkins commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before the change?

After the change?

Pull request checklist

Does this introduce a breaking change?

Uh oh!

nickfloyd commented Jan 13, 2026

Uh oh!

stevehipwell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ErikElkins commented Jan 13, 2026

Uh oh!

ErikElkins commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ErikElkins commented Jan 13, 2026

Uh oh!

gateixeira left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gateixeira left a comment

Choose a reason for hiding this comment

Uh oh!

stevehipwell commented Feb 24, 2026

Uh oh!

Uh oh!

Uh oh!

deiga commented Mar 24, 2026

Uh oh!

ErikElkins commented Mar 24, 2026

Uh oh!

stevehipwell left a comment

Choose a reason for hiding this comment

Uh oh!

stevehipwell commented Apr 1, 2026

Uh oh!

robert-crandall left a comment

Choose a reason for hiding this comment

Uh oh!

ErikElkins commented Apr 2, 2026

Uh oh!

deiga commented Apr 2, 2026

Uh oh!

LornaJoyce commented Apr 13, 2026

Uh oh!

deiga commented Apr 13, 2026

Uh oh!

ErikElkins commented Apr 13, 2026

Uh oh!

stevehipwell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ErikElkins commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ErikElkins commented May 2, 2025 •

edited

Loading

ErikElkins commented Jan 13, 2026 •

edited

Loading