Skip to content

feat: Add support for multi var/envvars in repos#2637

Closed
bradam12 wants to merge 11 commits intointegrations:mainfrom
bradam12:feat-2526-multi-var
Closed

feat: Add support for multi var/envvars in repos#2637
bradam12 wants to merge 11 commits intointegrations:mainfrom
bradam12:feat-2526-multi-var

Conversation

@bradam12
Copy link
Copy Markdown
Contributor

@bradam12 bradam12 commented Apr 25, 2025

Resolves #2526


Before the change?

N/A (new feature)

After the change?

  • Able to manage repo variables and repo environment variables in a single resource.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@bradam12
Copy link
Copy Markdown
Contributor Author

@kfcampbell @nickfloyd for your review!

@nickfloyd nickfloyd moved this from 🆕 Triage to 👀 In review in 🧰 Octokit Active Jun 3, 2025
@github-actions github-actions Bot added Type: Feature New feature or request Type: Documentation Improvements or additions to documentation labels Nov 12, 2025
@deiga
Copy link
Copy Markdown
Collaborator

deiga commented Dec 17, 2025

Hey @bradam12 👋

Thank you for your contribution! Could you describe your need here in more detail?
Since each variable will need to have it's own API call, what is the benefit using this versus github_actions_variable with a for_each loop?

@bradam12
Copy link
Copy Markdown
Contributor Author

Hey @bradam12 👋

Thank you for your contribution! Could you describe your need here in more detail? Since each variable will need to have it's own API call, what is the benefit using this versus github_actions_variable with a for_each loop?

It's fairly documented in #2526. Reads can be done in one API call (per 100 variables), so future plans are much quicker and burn less API calls. Applys still write one at a time.

@deiga
Copy link
Copy Markdown
Collaborator

deiga commented Dec 17, 2025

Hmm, I see.

I understand that the read can be quite consuming of the API rate.

The implementation you proposed here has me worried that failures in one API call will leave the resource in an wonky state.

@deiga
Copy link
Copy Markdown
Collaborator

deiga commented Mar 22, 2026

While this might reduce the amount of API calls in some situations, the implementation is not something that the provider can support.
Having an "unlimited" number of "sub-resources" that each require it's own API calls would make this resource incredibly brittle to weird state issues due to network flukes or rate limit throttling.

Thanks for the contribution!

@deiga deiga closed this Mar 22, 2026
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in 🧰 Octokit Active Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Documentation Improvements or additions to documentation Type: Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Reduce API throttling by reading all env variables per env at once.

4 participants