Skip to content

Commit 9750a01

Browse files
committed
fix: correct GraphQL API field types for excludedTeamMemberIds
- Change ExcludedTeamMemberIds field type from []string to []githubv4.ID - Convert string node IDs to githubv4.ID type when building exclusion list - Ensures compliance with GitHub GraphQL API specification for UpdateTeamReviewAssignmentInput
1 parent 638bd45 commit 9750a01

1 file changed

Lines changed: 13 additions & 13 deletions

File tree

github/resource_github_team_settings.go

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,22 +13,22 @@ import (
1313
// getUserNodeId retrieves the GraphQL node ID for a given username
1414
func getUserNodeId(ctx context.Context, meta interface{}, username string) (string, error) {
1515
client := meta.(*Owner).v4client
16-
16+
1717
var query struct {
1818
User struct {
1919
ID githubv4.ID `graphql:"id"`
2020
} `graphql:"user(login: $username)"`
2121
}
22-
22+
2323
variables := map[string]interface{}{
2424
"username": githubv4.String(username),
2525
}
26-
26+
2727
err := client.Query(ctx, &query, variables)
2828
if err != nil {
2929
return "", fmt.Errorf("failed to query user %s: %v", username, err)
3030
}
31-
31+
3232
return string(query.User.ID.(githubv4.String)), nil
3333
}
3434

@@ -210,7 +210,7 @@ func resourceGithubTeamSettingsUpdate(d *schema.ResourceData, meta any) error {
210210
} `graphql:"updateTeamReviewAssignment(input:$input)"`
211211
}
212212

213-
exclusionList := make([]string, 0)
213+
exclusionList := make([]githubv4.ID, 0)
214214
if excludedMembers, ok := settings["excluded_team_members"]; ok && excludedMembers != nil {
215215
for _, v := range excludedMembers.(*schema.Set).List() {
216216
if v != nil {
@@ -219,7 +219,7 @@ func resourceGithubTeamSettingsUpdate(d *schema.ResourceData, meta any) error {
219219
if err != nil {
220220
return fmt.Errorf("failed to get node ID for user %s: %v", username, err)
221221
}
222-
exclusionList = append(exclusionList, nodeId)
222+
exclusionList = append(exclusionList, githubv4.ID(nodeId))
223223
}
224224
}
225225
}
@@ -300,13 +300,13 @@ func resolveTeamIDs(idOrSlug string, meta *Owner, ctx context.Context) (nodeId,
300300
}
301301

302302
type UpdateTeamReviewAssignmentInput struct {
303-
ClientMutationID string `json:"clientMutationId,omitempty"`
304-
TeamID string `graphql:"id" json:"id"`
305-
ReviewRequestDelegation bool `graphql:"enabled" json:"enabled"`
306-
ReviewRequestDelegationAlgorithm string `graphql:"algorithm" json:"algorithm"`
307-
ReviewRequestDelegationCount int `graphql:"teamMemberCount" json:"teamMemberCount"`
308-
ReviewRequestDelegationNotifyAll bool `graphql:"notifyTeam" json:"notifyTeam"`
309-
ExcludedTeamMemberIds []string `graphql:"excludedTeamMemberIds" json:"excludedTeamMemberIds"`
303+
ClientMutationID string `json:"clientMutationId,omitempty"`
304+
TeamID string `graphql:"id" json:"id"`
305+
ReviewRequestDelegation bool `graphql:"enabled" json:"enabled"`
306+
ReviewRequestDelegationAlgorithm string `graphql:"algorithm" json:"algorithm"`
307+
ReviewRequestDelegationCount int `graphql:"teamMemberCount" json:"teamMemberCount"`
308+
ReviewRequestDelegationNotifyAll bool `graphql:"notifyTeam" json:"notifyTeam"`
309+
ExcludedTeamMemberIds []githubv4.ID `graphql:"excludedTeamMemberIds" json:"excludedTeamMemberIds"`
310310
}
311311

312312
func defaultTeamReviewAssignmentSettings(id string) UpdateTeamReviewAssignmentInput {

0 commit comments

Comments
 (0)