refactor: improve UX by accepting usernames instead of node IDs

- Change excluded_team_member_node_ids to excluded_team_members
- Accept GitHub usernames instead of GraphQL node IDs
- Add getUserNodeId helper function to lookup node IDs automatically
- Update tests to use friendly usernames like 'octocat', 'defunkt'
- Update documentation with simpler examples
- Makes configuration much more user-friendly and intuitive

Author: janeklb

github/resource_github_team_settings.go

@@ -10,6 +10,28 @@ import (
 	"github.com/shurcooL/githubv4"
 )
 
+// getUserNodeId retrieves the GraphQL node ID for a given username
+func getUserNodeId(ctx context.Context, meta interface{}, username string) (string, error) {
+	client := meta.(*Owner).v4client
+	
+	var query struct {
+		User struct {
+			ID githubv4.ID `graphql:"id"`
+		} `graphql:"user(login: $username)"`
+	}
+	
+	variables := map[string]interface{}{
+		"username": githubv4.String(username),
+	}
+	
+	err := client.Query(ctx, &query, variables)
+	if err != nil {
+		return "", fmt.Errorf("failed to query user %s: %v", username, err)
+	}
+	
+	return string(query.User.ID.(githubv4.String)), nil
+}
+
 func resourceGithubTeamSettings() *schema.Resource {
 	return &schema.Resource{
 		Create: resourceGithubTeamSettingsCreate,
@@ -83,10 +105,10 @@ func resourceGithubTeamSettings() *schema.Resource {
 							Default:     false,
 							Description: "whether to notify the entire team when at least one member is also assigned to the pull request.",
 						},
-						"excluded_team_member_node_ids": {
+						"excluded_team_members": {
 							Type:        schema.TypeSet,
 							Optional:    true,
-							Description: "A list of team member node IDs to exclude from the PR review process.",
+							Description: "A list of team member usernames to exclude from the PR review process.",
 							Elem: &schema.Schema{
 								Type: schema.TypeString,
 							},
@@ -189,10 +211,15 @@ func resourceGithubTeamSettingsUpdate(d *schema.ResourceData, meta any) error {
 			}
 
 			exclusionList := make([]string, 0)
-			if excludedIDs, ok := settings["excluded_team_member_node_ids"]; ok && excludedIDs != nil {
-				for _, v := range excludedIDs.(*schema.Set).List() {
+			if excludedMembers, ok := settings["excluded_team_members"]; ok && excludedMembers != nil {
+				for _, v := range excludedMembers.(*schema.Set).List() {
 					if v != nil {
-						exclusionList = append(exclusionList, v.(string))
+						username := v.(string)
+						nodeId, err := getUserNodeId(ctx, meta, username)
+						if err != nil {
+							return fmt.Errorf("failed to get node ID for user %s: %v", username, err)
+						}
+						exclusionList = append(exclusionList, nodeId)
 					}
 				}
 			}

github/resource_github_team_settings_test.go

@@ -138,7 +138,7 @@ func TestAccGithubTeamSettings(t *testing.T) {
 					algorithm = "ROUND_ROBIN"
 					member_count = 1
 					notify = true
-					excluded_team_member_node_ids = ["MDQ6VXNlcjU4MzIzMQ==", "MDQ6VXNlcjU4MzIzMg=="]
+					excluded_team_members = ["octocat", "defunkt"]
 				}
 			}
 		`, teamName)
@@ -149,7 +149,7 @@ func TestAccGithubTeamSettings(t *testing.T) {
 				"ROUND_ROBIN",
 			),
 			resource.TestCheckResourceAttr(
-				"github_team_settings.test", "review_request_delegation.0.excluded_team_member_node_ids.#",
+				"github_team_settings.test", "review_request_delegation.0.excluded_team_members.#",
 				"2",
 			),
 		)

website/docs/r/team_settings.html.markdown

@@ -30,7 +30,7 @@ resource "github_team_settings" "code_review_settings" {
       algorithm = "ROUND_ROBIN"
       member_count = 1
       notify = true
-      excluded_team_member_node_ids = ["MDQ6VXNlcjU4MzIzMQ=="]
+      excluded_team_members = ["octocat", "defunkt"]
   }
 }
 ```
@@ -49,7 +49,7 @@ The following arguments are supported:
 * `algorithm` - (Optional) The algorithm to use when assigning pull requests to team members. Supported values are `ROUND_ROBIN` and `LOAD_BALANCE`. Default value is `ROUND_ROBIN`
 * `member_count` - (Optional) The number of team members to assign to a pull request
 * `notify` - (Optional) whether to notify the entire team when at least one member is also assigned to the pull request
-* `excluded_team_member_node_ids` - (Optional) A list of team member node IDs to exclude from the PR review process. These are GitHub user node IDs that can be obtained from the GitHub GraphQL API.
+* `excluded_team_members` - (Optional) A list of team member usernames to exclude from the PR review process.
 
 
 ## Import