Don't report write races for loops that have a single iteration#1007
Open
majosm wants to merge 2 commits intoinducer:mainfrom
Open
Don't report write races for loops that have a single iteration#1007majosm wants to merge 2 commits intoinducer:mainfrom
majosm wants to merge 2 commits intoinducer:mainfrom
Conversation
majosm
force-pushed
the
ignore-single-iteration-write-races
branch
from
e4aad6b to
d6d153c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
realize_reductiongenerates code for thread-parallel reductions, the last stage of the reduction is a loop nest over workgroup and thread that assigns to a variable that is only indexed by workgroup.check_for_write_racesreports this as a race, but since the thread loop only has one iteration (thread 0), it isn't really. This change tightens the race check to avoid the false positive.