Skip to content

Escape angle brackets in serializer attribute tests#192

Merged
annevk merged 1 commit intohtml5lib:masterfrom
EmilStenstrom:issue-191-quote-attributes
Apr 19, 2026
Merged

Escape angle brackets in serializer attribute tests#192
annevk merged 1 commit intohtml5lib:masterfrom
EmilStenstrom:issue-191-quote-attributes

Conversation

@EmilStenstrom
Copy link
Copy Markdown
Contributor

Summary

Fixes #191.

@EmilStenstrom
Copy link
Copy Markdown
Contributor Author

EmilStenstrom commented Jan 29, 2026

Note:

  • The nokogiri and parse5 failures below are related to the selectedcontent changes, I see no failures connected to my change above, which points to the fact that serializers tests are not run for those parsers.
  • No failures for html5gum and skeleton points to no serializer tests being run on those platforms either.

@EmilStenstrom
Copy link
Copy Markdown
Contributor Author

EmilStenstrom commented Mar 17, 2026

@annevk Mind reviewing this as well? :)

Copy link
Copy Markdown
Contributor

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these tests not run in browsers? I didn't notice these when fixing the behavior in WebKit. @zcorpan do you know?

@EmilStenstrom
Copy link
Copy Markdown
Contributor Author

@annevk What's the right process to get a merge here?

@annevk annevk merged commit 85c968a into html5lib:master Apr 19, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serializer tests do not quote < and > in attributes

2 participants