Refactor transport tests to better report pattern match failures#484
Merged
LaurentRDC merged 1 commit intomasterfrom Apr 21, 2026
Merged
Refactor transport tests to better report pattern match failures#484LaurentRDC merged 1 commit intomasterfrom
LaurentRDC merged 1 commit intomasterfrom
Conversation
26a97c4 to
e8d08cd
Compare
e8d08cd to
c7269b4
Compare
Member
Author
|
I think I have a fix for the QUIC flaky tests, but this is going to be in a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many tests from
network-transport-testsuse partial pattern matches to test expectations. Unfortunately, this leads to hard-to-debug problems.This PR adds functionality to
network-transport-teststo express expectations in a way that makes it easier to report problems. See below for an example.Before:
Now: