Skip to content

chore: Fix flaky unit tests #6740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Fix flaky unit tests #6740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions google/cloud/aiplatform/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,10 @@ class VertexAiResourceNoun(metaclass=abc.ABCMeta):
service representation of the resource noun.
"""

def __new__(cls, *args, **kwargs):
"""Explicit __new__ to prevent argument forwarding to object.__new__."""
return super().__new__(cls)

@property
@classmethod
@abc.abstractmethod
Expand Down
2 changes: 0 additions & 2 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@
"3.11": ["2.42.0", "2.47.1"],
}
UNIT_TEST_STANDARD_DEPENDENCIES = [
"mock",
"asyncmock",
"pytest",
"pytest-cov",
"pytest-asyncio",
Expand Down
1 change: 0 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,6 @@
"kfp >= 2.6.0, < 3.0.0; python_version<'3.13'",
"pytest-asyncio",
"pytest-cov",
"mock",
"pytest-xdist",
"Pillow",
"scikit-learn<1.6.0; python_version<='3.10'",
Expand Down
33 changes: 16 additions & 17 deletions vertexai/resources/preview/feature_store/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,21 +51,20 @@
)

__all__ = (
Feature,
FeatureGroup,
FeatureGroupBigQuerySource,
FeatureMonitor,
FeatureOnlineStoreType,
FeatureOnlineStore,
FeatureView,
FeatureViewBigQuerySource,
FeatureViewReadResponse,
FeatureViewVertexRagSource,
FeatureViewRegistrySource,
IndexConfig,
IndexConfig,
TreeAhConfig,
BruteForceConfig,
DistanceMeasureType,
AlgorithmConfig,
"Feature",
"FeatureGroup",
"FeatureGroupBigQuerySource",
"FeatureMonitor",
"FeatureOnlineStoreType",
"FeatureOnlineStore",
"FeatureView",
"FeatureViewBigQuerySource",
"FeatureViewReadResponse",
"FeatureViewVertexRagSource",
"FeatureViewRegistrySource",
"IndexConfig",
"TreeAhConfig",
"BruteForceConfig",
"DistanceMeasureType",
"AlgorithmConfig",
)
12 changes: 6 additions & 6 deletions vertexai/resources/preview/feature_store/feature_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,20 @@
from google.cloud.aiplatform import base, initializer
from google.cloud.aiplatform import utils
from google.cloud.aiplatform.compat.types import (
feature as gca_feature,
feature_group as gca_feature_group,
io as gca_io,
feature_monitor_v1beta1 as gca_feature_monitor,
feature as gca_feature,
io as gca_io,
)
from vertexai.resources.preview.feature_store.utils import (
FeatureGroupBigQuerySource,
)
from vertexai.resources.preview.feature_store import (
from vertexai.resources.preview.feature_store.feature import (
Feature,
)
from vertexai.resources.preview.feature_store.feature_monitor import (
FeatureMonitor,
)
from vertexai.resources.preview.feature_store.utils import (
FeatureGroupBigQuerySource,
)


_LOGGER = base.Logger(__name__)
Expand Down
Loading