test/nginx/setup-odk: increase global teardown timeout - #2130
Merged
Conversation
Seen to timeout after 2.1 seconds: https://github.com/getodk/central/actions/runs/31661302771/job/94326512906?pr=2104 Ref getodk#2104
matthew-white
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen to timeout after 2.1 seconds: https://github.com/getodk/central/actions/runs/31661302771/job/94326512906?pr=2104
Ref #2104
What has been done to verify that this works as intended?
I didn't bother running exhaustively, as it seems like a simple change. And if there's a problem, a new fix should also be simple.
Why is this the best possible solution? Were any other approaches considered?
Seems like a legit timeout, so increasing the timeout 2.5x seems like a decent buffer.
How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
No effect or risk.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.