Audio connections v34 migration - #96
Merged
Merged
Conversation
Add the structured registry mutation API, the panel state model, the native window, and the command/menu wiring. Rows are read from the project registry each render; every edit goes through the mutation API, which reports whether runtime routing must be recompiled (a rename does not). Co-Authored-By: Claude Opus 5 <[email protected]>
Bus Name becomes an inline rename using the shared Studio text input; Configuration, Audio Device, and the Left/Right port cells become dropdowns backed by the registry's device_choices/port_choices. Adds keyboard selection, Tab cell traversal, layered Escape dismissal, and popover flip-up via the shared placement rule. Co-Authored-By: Claude Opus 5 <[email protected]>
Open Audio Connections through the same top-level window path as the external Mixer instead of as an owned dialog: WindowKind::Normal, no dialog parenting, real titlebar/taskbar/minimize, and the shared drawn titlebar rather than an ad-hoc in-content header and Close button. The project stays fully usable while it is open. Lay the table out from the width the window actually has. Fixed columns (On, Configuration, Status) keep their size; Bus Name, Audio Device, and the two port columns take the surplus, with Audio Device weighted highest. Below the floor the table scrolls horizontally instead of overlapping cells, and every cell carries a tooltip with its full label. Anchor popovers to the column layout and the row grid, both in this window's own coordinate space, so they follow a resize and never derive geometry from the main window. Keep the logical Bus Name independent of the hardware endpoint: the generated migration/Add-Track name no longer prefixes the device name, and the Audio Device column now shows the endpoint name instead of the opaque device id. Channel lists were already enumerated from the reported channel count; tests now pin that at 1, 2, 6, 8, 16, and 32 channels. Move Remove and Reset Defaults confirmation to the shared message-box window. The panel raises RequestRemove / RequestResetDefaults and the layout decides, since only it knows what references a bus. Window geometry is session state and is not written to the project. Co-Authored-By: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.