Skip to content

Feature flags#146

Open
NonSwag wants to merge 77 commits intomainfrom
feat/feature-flags
Open

Feature flags#146
NonSwag wants to merge 77 commits intomainfrom
feat/feature-flags

Conversation

@NonSwag
Copy link
Copy Markdown
Member

@NonSwag NonSwag commented Apr 17, 2026

Added:

  • Feature flags, Attributes, Settings, Feature flag service

Breaking:

  • Token, debug, and URL are no longer defined via the metrics factory but instead a Settings instance

@NonSwag NonSwag self-assigned this Apr 17, 2026
@NonSwag NonSwag added the enhancement New feature or request label Apr 17, 2026
@NonSwag NonSwag force-pushed the feat/feature-flags branch 2 times, most recently from cf1ef1c to f590875 Compare April 22, 2026 13:13
@LuggaPugga
Copy link
Copy Markdown
Member

LuggaPugga commented Apr 29, 2026

Could we rename the hash you are giving me to group_hash?
It would be a bit clearer on my side, as I also have an internal exact hash to avoid saving a stack trace multiple times.

@NonSwag
Copy link
Copy Markdown
Member Author

NonSwag commented Apr 29, 2026

Yes but you would have to do it in a backwards compatible manner on your side since the hash existed before this pr

@LuggaPugga
Copy link
Copy Markdown
Member

LuggaPugga commented Apr 29, 2026

Yes but you would have to do it in a backwards compatible manner on your side since the hash existed before this pr

We didn’t really use it before, since we created the parameterized hash on the server.
Using the exact hash for older versions should be fine, as the behavior would be pretty much the same

@NonSwag NonSwag force-pushed the feat/feature-flags branch from 8a4fd5e to 0229ec9 Compare April 29, 2026 17:06
NonSwag added 22 commits May 5, 2026 16:17
@NonSwag
Refactor feature flags
be92623
@NonSwag
Split metrics and flags url into separate values
1075b01
@NonSwag
Throw on non-finite numbers
8a50cb7
@NonSwag
Replace Object with JsonPrimitive in Attributes
24f52d6
@NonSwag
Add Type enum to FeatureFlags
14c4fb5
@NonSwag
Refactor SimpleFeatureFlagService
eee9708
@NonSwag
Generalize terms in onboarding message and default config
475e5c5
@NonSwag
Refactored logging
b89b687
@NonSwag
Removed settings and ability to define metrics URL and debug
cff4cb4
@NonSwag
Document FeatureFlags
b079fe5
@NonSwag
Document Attributes#forEachPrimitive
c166d31
@NonSwag
Use correct url
28e80f3
@NonSwag
Make SDK properties static
3756832
@NonSwag
Add minimal logger api
e89921d
@NonSwag
Extracts constants to its own class
0ffb84e
@NonSwag
Add dedicated Hytale logger
e864680
@NonSwag
Use custom filter predicate
7b9d10b
@NonSwag
Move logger below metrics server url
75a6584
@NonSwag
Removed unused imports
75e7056
@NonSwag
Replace Gson#toJson with toString
2952541
@NonSwag
Add logger to feature flag service
70c1576
@NonSwag
Decouple config from Metrics interface
8a1a21a
NonSwag added 26 commits May 5, 2026 16:18
@NonSwag
Rename isLibraryClass to isLibraryFrame
c1ecdd8
@NonSwag
Integrate stacktrace fingerprinting
fb7a5f8
@NonSwag
Add stacktrace fingerprinting tests
406e320
@NonSwag
Fix inverted condition
2b09733
@NonSwag
Add method contracts
96d2039
@NonSwag
Do not fetch eagerly
4ae7f08
@NonSwag
No need to cache the logger
b4d5454
@NonSwag
Reword feature-flags virtual constructor javadocs description
17ca59b
@NonSwag
Move fetch times and cache to flag implementation
02861c7
@NonSwag
Add logger name to error log record
f658c67
@NonSwag
Add debug logs to feature flag fetches
f5fc862
@NonSwag
Note exceptional behavior for feature flag fetches
5fb6779
@NonSwag
Link to #fetch
8b87431
@NonSwag
Link to #whenReady
446887b
@NonSwag
Clarify #getChaged docs
a30eb38
@NonSwag
Simplified code structure
8be66e7
@NonSwag
Update feature flags example
62e8b94
@NonSwag
Fix url resolving
f7862e2
@NonSwag
Rename serverId to identifier
60a8c47
@NonSwag
Add more debug logs
2986bbe
@NonSwag
Simplify opt request callback
8b42365
@NonSwag
Simplify error tracker entry creation
b02a647
@NonSwag
Rename reported "hash" to "group_hash"
ca9f502
@NonSwag
remove useless test
a226326
@NonSwag
Remove opt-in and out API
f2429f1
@NonSwag
Improve number and boolean parsing
12e7043
@NonSwag NonSwag force-pushed the feat/feature-flags branch from 65d37b3 to 12e7043 Compare May 5, 2026 14:18
@NonSwag
Remove error fingerprinting
f80aa84 
Moved to a separate branch and PR
@NonSwag NonSwag force-pushed the feat/feature-flags branch 2 times, most recently from 6c983cd to f80aa84 Compare May 5, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@NonSwag NonSwag

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NonSwag @LuggaPugga