docs: use triple backticks instead of @theme/CodeBlock component#1038
Closed
JamBalaya56562 wants to merge 1 commit intofacebook:mainfrom
JamBalaya56562:codeblock
Closed
docs: use triple backticks instead of @theme/CodeBlock component#1038JamBalaya56562 wants to merge 1 commit intofacebook:mainfrom JamBalaya56562:codeblock
@theme/CodeBlock component#1038JamBalaya56562 wants to merge 1 commit intofacebook:mainfrom
JamBalaya56562:codeblock
Conversation
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
Contributor
|
@JamBalaya56562 has updated the pull request. You must reimport the pull request before landing. |
3 similar comments
Contributor
|
@JamBalaya56562 has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@JamBalaya56562 has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@JamBalaya56562 has updated the pull request. You must reimport the pull request before landing. |
…ich doesn't use variable
Contributor
|
@JamBalaya56562 has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
This pull request has been merged in 718e3af. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The code blocks in Installation docs is different from the others.
Installation code blocks are surrounded by
@theme/CodeBlockcomponent.This is useful to use variables.
However, this makes the unnecessary new line.
Moreover, copy and paste button doesn't show.
Image1:
@theme/CodeBlockcomponentImage2: triple backticks
Therefore, we should use triple backticks instead of
@theme/CodeBlockif variables don't exist.