ci(tests): Cleanup workflow runs by crankynetman · Pull Request #231 · esnet-security/SCRAM

crankynetman · 2026-05-04T20:42:37Z

This PR cleans up our workflows to run on a per-app basis and upload things in the same manner. It also renames all of the make targets to test-application to get ride of behave vs pytest and all the confusion there. Now it just runs the tests for one of the applications. You can still call pytest and behave but the targets are all simplified.

Finally, this adds a make target ci-act (act needs to be installed via brew locally) which allows you to test GH actions locally. Works pretty well.

I also restructured the Makefile. It was way too out of order and the names didn't make sense anymore as we've scaled things. Changes are:

Renamed:

behave-all to behave-django (it was all for ALL features (in django only lol)
behave to behave-django-feature (keeping this around but I feel like we should get rid of it or make it generic enough to work for translator behave too)
integration-tests to integration-django
pytest to pytest-django
pytest-scheduler to test-scheduler
pytest-scripts to test-scripts

Removed:

coverage.xml . We now just have per-app coverage steps inside the test targets. And we just now always run coverage cuz it's not that big a deal to do.

Added/Significantly modified:

behave-translator. This wasn't added, but now it has coverage, doesn't just run tests.
test-django. runs all tests for django (pytest-django + behave-django + integration-django)
test-translator: builds/runs stack + runs behave-translator
test: runs all four test-* targets (so in theory ALL test types)
ci-test: runs all CI workflows locally via act (old ci-test didn't mirror CI at all).
behave-translator-feature. Allows you to run just one behave feature for translator.

Should close #200 and #219.

…1 directory (#227) Bumps the uv group with 1 update in the / directory: [tornado](https://github.com/tornadoweb/tornado). Updates `tornado` from 6.5.4 to 6.5.5 <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst">tornado's changelog</a>. <blockquote> <h1>Release notes</h1> .. toctree:: :maxdepth: 2 releases/v6.5.5 releases/v6.5.4 releases/v6.5.3 releases/v6.5.2 releases/v6.5.1 releases/v6.5.0 releases/v6.4.2 releases/v6.4.1 releases/v6.4.0 releases/v6.3.3 releases/v6.3.2 releases/v6.3.1 releases/v6.3.0 releases/v6.2.0 releases/v6.1.0 releases/v6.0.4 releases/v6.0.3 releases/v6.0.2 releases/v6.0.1 releases/v6.0.0 releases/v5.1.1 releases/v5.1.0 releases/v5.0.2 releases/v5.0.1 releases/v5.0.0 releases/v4.5.3 releases/v4.5.2 releases/v4.5.1 releases/v4.5.0 releases/v4.4.3 releases/v4.4.2 releases/v4.4.1 releases/v4.4.0 releases/v4.3.0 releases/v4.2.1 releases/v4.2.0 releases/v4.1.0 releases/v4.0.2 releases/v4.0.1 releases/v4.0.0 releases/v3.2.2 releases/v3.2.1 releases/v3.2.0 releases/v3.1.1  </blockquote> ... (truncated) </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/tornadoweb/tornado/commit/7d6465056ceb7a054b3f64cf1c18271753b10482"><code>7d64650</code></a> Merge pull request <a href="https://redirect.github.com/tornadoweb/tornado/issues/3586">#3586</a> from bdarnell/update-cibw</li> <li><a href="https://github.com/tornadoweb/tornado/commit/d05d59b8080a0d5d6a260994c7aad7049209d345"><code>d05d59b</code></a> build: Bump cibuildwheel to 3.4.0</li> <li><a href="https://github.com/tornadoweb/tornado/commit/c2f46732b0ad14bf0db4219c96a945f4b60205f5"><code>c2f4673</code></a> Merge pull request <a href="https://redirect.github.com/tornadoweb/tornado/issues/3585">#3585</a> from bdarnell/release-655</li> <li><a href="https://github.com/tornadoweb/tornado/commit/e5f1aa4b6fa2c16b29024830227838fcb0c79b6f"><code>e5f1aa4</code></a> Release notes and version bump for v6.5.5</li> <li><a href="https://github.com/tornadoweb/tornado/commit/78a046f99f89977dfc8ff5a1fe16d298afbeeaca"><code>78a046f</code></a> httputil: Add CRLF to _FORBIDDEN_HEADER_CHARS_RE</li> <li><a href="https://github.com/tornadoweb/tornado/commit/24a2d96ea115f663b223887deb0060f13974c104"><code>24a2d96</code></a> web: Validate characters in all cookie attributes.</li> <li><a href="https://github.com/tornadoweb/tornado/commit/119a195e290c43ad2d63a2cf012c29d43d6ed839"><code>119a195</code></a> httputil: Add limits on multipart form data parsing</li> <li>See full diff in <a href="https://github.com/tornadoweb/tornado/compare/v6.5.4...v6.5.5">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tornado&package-manager=uv&previous-version=6.5.4&new-version=6.5.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/esnet-security/SCRAM/network/alerts). </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chris Cummings <[email protected]>

Co-authored-by: Copilot <[email protected]>

github-actions · 2026-05-04T20:43:04Z

Scheduler Coverage

File	Coverage
All files	`100%`	✅

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against c7d15e9

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

…net-security/SCRAM into topic/chriscummings/cleanup-test-runs

Co-authored-by: Copilot <[email protected]>

github-actions · 2026-05-04T21:01:06Z

Scripts Coverage

File	Coverage
All files	`50%`	✅
scripts/extract_env_vars.py	`50%`	✅

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against c7d15e9

github-actions · 2026-05-04T21:08:24Z

Django Coverage

File	Coverage
All files	`78%`	✅
src/config/consumers.py	`59%`	❌
src/config/urls.py	`69%`	❌
src/config/settings/base.py	`69%`	❌
src/config/settings/local.py	`72%`	✅
src/scram/route_manager/admin.py	`71%`	✅
src/scram/route_manager/models.py	`79%`	✅
src/scram/route_manager/views.py	`88%`	✅
src/scram/route_manager/api/serializers.py	`92%`	✅
src/scram/route_manager/api/views.py	`63%`	❌
src/scram/shared/shared_code.py	`56%`	❌
src/scram/templates/403.html	`93%`	✅
src/scram/templates/404.html	`93%`	✅

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against c7d15e9

Co-authored-by: Copilot <[email protected]>

github-actions · 2026-05-04T22:07:46Z

Translator Coverage

File	Coverage
All files	`85%`	✅
translator/src/translator/__init__.py	`0%`	❌
translator/src/translator/exceptions.py	`50%`	❌
translator/src/translator/gobgp.py	`85%`	✅
translator/src/translator/settings.py	`91%`	✅
translator/src/translator/shared.py	`81%`	✅

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against c7d15e9

samoehlert · 2026-05-05T16:10:25Z

  workflow_dispatch:

+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}


this concurrency is a bit fuzzy to me. my best guess is that we run all the workflow file for a specific PR concurrently. so for example this whole django workflow would run concurrently for a given PR and cancel any other jobs if one fails?

samoehlert · 2026-05-05T16:50:41Z

+	@$(ACT) push --workflows .github/workflows/scheduler.yml
+	@$(ACT) push --workflows .github/workflows/translator.yml
+	@$(ACT) push --workflows .github/workflows/django.yml
+# 	@$(ACT) push --workflows .github/workflows/type-check.yml


Can we remove commented out code?

samoehlert · 2026-05-05T16:53:17Z

I see the 4 neutral checks that say "Run Scheduler Tests" but then they are actually for different coverages. i cant quite figure out why, but it would be nice to see that cleaned up.

dependabot Bot and others added 2 commits May 1, 2026 21:26

ci(gh-actions): cleanup workflows and add act

974db7e

Co-authored-by: Copilot <[email protected]>

github-advanced-security AI found potential problems May 4, 2026

View reviewed changes

Comment thread .github/workflows/scheduler.yml Fixed

Comment thread .github/workflows/scripts.yml Fixed

Comment thread .github/workflows/translator.yml Fixed

crankynetman and others added 10 commits May 4, 2026 15:44

set wf to read for explicit permissions

68e53fd

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

chore(gh-actions): add explicit permissions

a8712b9

Merge branch 'main' into topic/chriscummings/cleanup-test-runs

848a16b

chore(lint): update whitespace

69664c1

chore(ruff): whitespace

57d4ec7

Merge branch 'topic/chriscummings/cleanup-test-runs' of github.com:es…

43d0558

…net-security/SCRAM into topic/chriscummings/cleanup-test-runs

chore(gh-actions): okay we need write perms for some things

06b0ba4

Co-authored-by: Copilot <[email protected]>

fix(gh-actions): finish renaming targets

5e8c9a2

fix(gh-actions): and some more!

3d5f5f3

Co-authored-by: Copilot <[email protected]>

ci(gh-actions): run more sanely

cf2e512

crankynetman changed the base branch from main to topic/chriscummings/uv-workspaces-django May 4, 2026 21:08

crankynetman and others added 4 commits May 4, 2026 16:49

chore(makefile): rename and re-order all targets for consistency

517a90e

Co-authored-by: Copilot <[email protected]>

feat(make): add equal targets for translator/django

307ac45

Co-authored-by: Copilot <[email protected]>

fix(gh-actions): call the correct make target..

12d928a

fix(tests): translator coverage should work now

9bc4603

Co-authored-by: Copilot <[email protected]>

crankynetman marked this pull request as draft May 4, 2026 22:13

ci(coverage): min coverage change for django

c7d15e9

crankynetman marked this pull request as ready for review May 5, 2026 01:25

samoehlert reviewed May 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(tests): Cleanup workflow runs#231

ci(tests): Cleanup workflow runs#231
crankynetman wants to merge 17 commits intotopic/chriscummings/uv-workspaces-djangofrom
topic/chriscummings/cleanup-test-runs

crankynetman commented May 4, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 4, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 4, 2026 •

edited

Loading

Uh oh!

samoehlert May 5, 2026

Uh oh!

samoehlert May 5, 2026

Uh oh!

samoehlert commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

crankynetman commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samoehlert May 5, 2026

Choose a reason for hiding this comment

Uh oh!

samoehlert May 5, 2026

Choose a reason for hiding this comment

Uh oh!

samoehlert commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

crankynetman commented May 4, 2026 •

edited

Loading

github-actions Bot commented May 4, 2026 •

edited

Loading

github-actions Bot commented May 4, 2026 •

edited

Loading

github-actions Bot commented May 4, 2026 •

edited

Loading

github-actions Bot commented May 4, 2026 •

edited

Loading