Skip to content

fix: update dependencies under @eslint scope #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lumirlumir wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: update dependencies under @eslint scope #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d17df76
chore: update dependencies under `@eslint` scope
lumirlumir Apr 6, 2026
d43e24c
Merge branch 'main' into chore/update-eslint-dependencies
lumirlumir Apr 9, 2026
7300886
wip
lumirlumir Apr 9, 2026
29aa23a
Merge branch 'main' into chore/update-eslint-dependencies
lumirlumir Apr 13, 2026
8ffaab4
Merge branch 'main' into chore/update-eslint-dependencies
lumirlumir Apr 13, 2026
e1c9ed4
Merge branch 'main' of https://github.com/eslint/code-explorer into c…
lumirlumir Apr 18, 2026
3a82250
Merge branch 'main' into chore/update-eslint-dependencies
lumirlumir Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
217 changes: 193 additions & 24 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@
"@codemirror/lang-markdown": "^6.5.0",
"@codemirror/language": "^6.12.3",
"@codemirror/view": "^6.41.0",
"@eslint/css": "^0.14.1",
"@eslint/css": "^1.1.0",
"@eslint/js": "^9.39.4",
"@eslint/json": "^0.14.0",
"@eslint/markdown": "^7.5.1",
"@eslint/json": "^1.2.0",
"@eslint/markdown": "^8.0.1",
Comment on lines +41 to +44
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These @eslint package updates now require Node.js ^20.19.0 || ^22.13.0 || >=24 (per their published engines). The repo currently declares "engines.node": ">= 20" and uses an unpinned ".nvmrc" of "20", which implies support for Node 20.0–20.18 even though installs will fail there. Please align the project's declared/CI Node version with the new minimum (e.g., bump engines.node and pin .nvmrc accordingly).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

@lumirlumir lumirlumir Apr 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears Netlify automatically installs the latest Node.js 20 during the build, so this seems safe:

image

Would it be better to specify Node.js 20 version more explicitly to ensure future compatibility?

Copy link
Copy Markdown
Member

@amareshsm amareshsm Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can surely specify the a node js version explicitly. This PR also raises a warning about the Node.js version compatibility:

One option is: ^20.19.0 || ^22.13.0 || >=24

However, since Node 20 reached end-of-life in April 2026, we could drop support for it entirely and move to a more forward-looking range: ^22.12.0 || >=24

This aligns with the requirements of @rolldown/[email protected], which officially supports: >=22.12.0 || ^24.0.0 (Node 20 is excluded)
Although the plugin still works on Node 20.19+, it shows warnings, so support is only partial.

For a cleaner and future-proof setup, it’s better to:
Use ^22.12.0 || >=24 in engines
Set .nvmrc to Node 22

Or if want to go practically we can have: ^20.19.0 || ^22.13.0 || >=24

Copy link
Copy Markdown
Contributor

@Pixel998 Pixel998 Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the same Node.js support issue with the eslint-scope update in #285 and the espree update in #284 as well. I filed #378 so we can discuss the project's Node.js version support.

Copy link
Copy Markdown
Member Author

@lumirlumir lumirlumir Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I believe an issue has been opened and there is no blocking problem for this PR since Netlify uses Node.js 20.20+. Should this PR be postponed, or can it be merged?

If it's acceptable, it would be nice if we can merge this PR without blocking, as the language plugin version discrepancy makes developing language plugins a bit difficult.

"@html-eslint/eslint-plugin": "^0.59.0",
"@lezer/highlight": "^1.2.3",
"@radix-ui/react-accordion": "^1.2.12",
Expand Down Expand Up @@ -73,7 +73,7 @@
},
"devDependencies": {
"@babel/core": "^7.29.0",
"@eslint/core": "^0.17.0",
"@eslint/core": "^1.2.1",
"@playwright/test": "^1.59.1",
"@rolldown/plugin-babel": "^0.2.2",
"@types/esquery": "^1.5.4",
Expand Down
Loading