Skip to content

fix: remove SubtestOutcome::Crash #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErichDonGubler merged 1 commit into from
Apr 8, 2025
Merged

fix: remove SubtestOutcome::Crash #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions moz-webgpu-cts/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,14 +685,6 @@ fn run(cli: Cli) -> ExitCode {
)
})
}
SubtestOutcome::Crash => receiver(&mut |analysis| {
insert_in_test_set(
&mut analysis.tests_with_crashes,
test_name,
expected,
outcome,
)
}),
SubtestOutcome::Fail => receiver(&mut |analysis| {
insert_in_subtest_by_test_set(
&mut analysis.subtests_with_failures_by_test,
Expand Down
3 changes: 0 additions & 3 deletions moz-webgpu-cts/src/wpt/metadata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,7 +1324,6 @@ pub enum SubtestOutcome {
Pass,
Fail,
Timeout,
Crash,
NotRun,
}

Expand All @@ -1343,7 +1342,6 @@ impl Display for SubtestOutcome {
Self::Pass => PASS,
Self::Fail => FAIL,
Self::Timeout => TIMEOUT,
Self::Crash => CRASH,
Self::NotRun => NOTRUN,
}
)
Expand All @@ -1360,7 +1358,6 @@ impl SubtestOutcome {
keyword(PASS).to(SubtestOutcome::Pass),
keyword(FAIL).to(SubtestOutcome::Fail),
keyword(TIMEOUT).to(SubtestOutcome::Timeout),
keyword(CRASH).to(SubtestOutcome::Crash),
keyword(NOTRUN).to(SubtestOutcome::NotRun),
))
}
Expand Down
Loading