Skip to content

Parse non-true values for disabled properties#143

Merged
ErichDonGubler merged 2 commits intomainfrom
correct-disabled-property
Apr 8, 2025
Merged

Parse non-true values for disabled properties#143
ErichDonGubler merged 2 commits intomainfrom
correct-disabled-property

Conversation

@ErichDonGubler
Copy link
Copy Markdown
Collaborator

@ErichDonGubler ErichDonGubler commented Aug 1, 2024

No description provided.

@ErichDonGubler ErichDonGubler changed the title WIP Parse non-true values for disabled properties Aug 1, 2024
@ErichDonGubler ErichDonGubler mentioned this pull request Aug 1, 2024
@sagudev

This comment was marked as outdated.

@ErichDonGubler ErichDonGubler force-pushed the correct-disabled-property branch from 6cc135a to 8e23d54 Compare March 20, 2025 18:01
@ErichDonGubler ErichDonGubler self-assigned this Mar 20, 2025
@ErichDonGubler ErichDonGubler marked this pull request as ready for review March 20, 2025 23:30
Comment thread moz-webgpu-cts/Cargo.toml Outdated
@ErichDonGubler ErichDonGubler force-pushed the correct-disabled-property branch from 8e23d54 to 96ea124 Compare March 29, 2025 20:52
@ErichDonGubler ErichDonGubler added the enhancement New feature or request label Apr 8, 2025
@ErichDonGubler ErichDonGubler moved this to In Progress in WebGPU for Firefox Apr 8, 2025
@ErichDonGubler ErichDonGubler force-pushed the correct-disabled-property branch 2 times, most recently from 18f5a55 to 509cb54 Compare April 8, 2025 15:45
Comment thread moz-webgpu-cts/src/wpt/metadata/properties.rs Outdated
@ErichDonGubler ErichDonGubler force-pushed the correct-disabled-property branch 10 times, most recently from 180c085 to d5a79ee Compare April 8, 2025 21:37
@ErichDonGubler ErichDonGubler enabled auto-merge April 8, 2025 21:40
@ErichDonGubler ErichDonGubler force-pushed the correct-disabled-property branch from 79e854d to 8d6bc37 Compare April 8, 2025 21:42
- Parse non-`true` strings and treat `@False` as
  specified-but-not-actually-disabled.
- Accept conditional values for `disabled`.
@ErichDonGubler ErichDonGubler force-pushed the correct-disabled-property branch from 8d6bc37 to cf6b3b8 Compare April 8, 2025 21:43
@ErichDonGubler ErichDonGubler merged commit f7e0119 into main Apr 8, 2025
34 checks passed
@ErichDonGubler ErichDonGubler deleted the correct-disabled-property branch April 8, 2025 21:49
@github-project-automation github-project-automation Bot moved this from In Progress to Done in WebGPU for Firefox Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants