CI: retry testem ci once on failure (Browserstack flake rescue)#21325
Open
johanrd wants to merge 1 commit intoemberjs:mainfrom
Open
CI: retry testem ci once on failure (Browserstack flake rescue)#21325johanrd wants to merge 1 commit intoemberjs:mainfrom
johanrd wants to merge 1 commit intoemberjs:mainfrom
Conversation
Contributor
|
to be fair tho, we did actually introduce an instability that we had to fix. my biggest worry with something like this is that we'll miss real problems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps
testem ciinbin/run-browserstack-tests.jsin a 2-attempt retry. If the second attempt also fails, the job fails normally. Avoiding ~15 false-positive CI failures per quarter is considered a bigger win than wasting ~9 unnecessary retries on failures the retry can't help.Occurrences last three months:
(2026-03-04)
TypeError: Load failed(Safari)(2026-04-06)
TypeError: Load failed(Safari)(2026-04-17)
TypeError: Load failed(Safari)(2026-04-20)
TypeError: Load failed(Safari, PR #32 motivating)(2026-03-19)
Assertion occurred after test finished(Safari)(2026-03-21)
Assertion occurred after test finished(Safari, onCan use hashtest)(2026-03-22)
Assertion occurred after test finished(Safari, onCan use hashtest)(2026-03-23)
Assertion occurred after test finished(Safari, onCan use hashtest)(2026-03-23)
Assertion occurred after test finished(Safari, onCan use hashtest)(2026-03-23)
Assertion occurred after test finished(Safari, onCan use hashtest)(2026-03-23)
Assertion occurred after test finished(Safari, onCan use hashtest)(2026-01-22)
Browser timeout exceeded: 120s(Safari)(2026-02-27)
Browser timeout exceeded: 120s(Safari)(2026-03-03)
Browser timeout exceeded: 120s(Chrome, oninstance tracking: tracks built instances)(2026-03-04)
Browser timeout exceeded: 120s(Chrome, on sameCan use hashtest)(2026-03-05)
Browser timeout exceeded: 120s(Safari, onRegistry: knownForType)(2026-03-05)
Browser timeout exceeded: 120s(Safari, onCan use Textarea)(2026-03-05)
Browser timeout exceeded: 120s(Safari, onDynamic content tests)(2026-01-26)
Browser exited unexpectedly(Chrome only; Safari + Edge passed)(2026-02-19)
(2026-03-04)
Browser exited unexpectedly(Chrome only; Safari + Edge passed)(2026-03-13)
Browser exited unexpectedly(Chrome + Edge; Safari passed)(2026-03-27)
(2026-04-04)
Browser exited unexpectedly(Chrome only; Safari + Edge passed)Caveats
Scoped to the BrowserStack-only job; Firefox/Chrome coverage in the regular browser-test job is unchanged. Testem doesn't expose a native retry option.
Cowritten by claude