Revert unnecessary change to normalize.ts#21255
Merged
NullVoxPopuli merged 1 commit intoemberjs:nvp/on-as-keyword-tremplate-the-transform-wayfrom Mar 26, 2026
Conversation
The change to make lexicalScope optional with a localsSet fallback is never exercised — the only caller (compiler.ts) always passes lexicalScope explicitly. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
NullVoxPopuli
merged commit 8e82ca8
into
emberjs:nvp/on-as-keyword-tremplate-the-transform-way
36 of 37 checks passed
NullVoxPopuli
added a commit
that referenced
this pull request
Apr 6, 2026
The change to make lexicalScope optional with a localsSet fallback is never exercised — the only caller (compiler.ts) always passes lexicalScope explicitly. Co-authored-by: NullVoxPopuli <[email protected]> Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/@glimmer/syntax/lib/v2/normalize.tsthat madelexicalScopeoptional with alocalsSetfallbackcompiler.ts:86) always passeslexicalScopeexplicitly:normalize(source, { lexicalScope: () => false, ...options })Test plan
🤖 Generated with Claude Code