[BUGFIX LTS] Fix crash *during* destroy in fastboot#21144
Merged
Conversation
Contributor
📊 Package size report -0%↓
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
Remove outdated comments regarding result association with root state.
ef4
approved these changes
Mar 4, 2026
Contributor
ef4
left a comment
ef4
left a comment
There was a problem hiding this comment.
This looks plausible to me. In general it seems best for the destroyable child edges to be a direct as possible. Skipping many levels from the container to the render result could be why we saw the problem.
Merged
12 tasks
kategengler
changed the title
Windvis
added a commit
to lblod/frontend-mandatendatabank
that referenced
this pull request
Mar 25, 2026
This doesn't actually work due do a fastboot issue that hasn't been backported yet to 6.8. Once that is released we can update to 6.8 More info: emberjs/ember.js#21144
st-h
pushed a commit
to st-h/vite-ember-ssr-server
that referenced
this pull request
Apr 6, 2026
Replace vm.SourceTextModule with vm.Script to avoid memory retention through Node.js timer infrastructure. The CJS bundle is compiled once and run in a fresh vm.createContext per request for full isolation. Key design decisions: - Per-request vm.createContext with isolated document, window, timers - Immediate-execution setTimeout(fn, 0) to let Ember's run loop flush synchronously without creating real timer entries - Wrapped fetch to prevent retention chains from vm.Context to global - process stub (env only) to avoid timer infrastructure references - Nothing set on the real global object per request Requires the SSR build to output CJS format (format: 'cjs', inlineDynamicImports: true in vite config). Also requires ember-source >= 6.11.1 which fixes a FastBoot destroy crash (emberjs/ember.js#21144) that prevented proper cleanup of per-request Application state. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #20984
Testing
pnpm installpnpm buildecho $PWD(copy this)pnpm installpnpm add $PATH_FROM_TERMINAL_1pnpm start