Skip to content

Remove ember cli htmlbars 6 support (classic builds now require use-ember-modules) #21137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NullVoxPopuli wants to merge 1 commit into from
Closed

Remove ember cli htmlbars 6 support (classic builds now require use-ember-modules) #21137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion smoke-tests/scenarios/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"@swc/types": "^0.1.6",
"@types/node": "^20.12.7",
"ember-cli-babel": "^8.3.1",
"ember-cli-htmlbars-6": "npm:ember-cli-htmlbars@^6.0.0",
"qunit": "^2.20.1",
"scenario-tester": "^4.0.0",
"typescript": "5.1",
Expand Down
9 changes: 0 additions & 9 deletions smoke-tests/scenarios/scenarios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
import { Project, Scenarios } from 'scenario-tester';
import { dirname } from 'node:path';

function classic(project: Project) {
// our monorepo uses pnpm overrides to force-upgrade ember-cli-htmlbars to 7,
// so that we can actually test the case where the use-ember-modules flag is
// enabled. This scenario ensures that when the flag is off, we still work
// with ember-cli-htmlbars 6.
project.linkDevDependency('ember-cli-htmlbars', { resolveName: 'ember-cli-htmlbars-6', baseDir: __dirname });
}

function classicUseModulesFeature(project: Project) {
project.mergeFiles({
config: {
Expand All @@ -32,7 +24,6 @@ function embroiderVite(project: Project) {}
export const v1AppScenarios = Scenarios.fromProject(() =>
Project.fromDir(dirname(require.resolve('../app-template/package.json')), { linkDevDeps: true })
).expand({
classic,
classicUseModulesFeature,
embroiderWebpack,
});
Expand Down
Loading