Skip to content

Commit f11a87b

Browse files
NullVoxPopuliclaude
andcommitted
Inline dasherize into strict-resolver.ts, drop the string/ directory
Follow-up to review: with cache.js gone, `string.js` was a 9-line file exporting just dasherize. Inline it as a private helper in strict-resolver.ts and delete the strict-resolver/ subdirectory (plus dasherize_test.js — dasherize's behavior is exercised via resolver.normalize(...) tests in basic-test.js). Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
1 parent a54e687 commit f11a87b

4 files changed

Lines changed: 6 additions & 47 deletions

File tree

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,6 @@
230230
"@ember/engine/instance.js": "ember-source/@ember/engine/instance.js",
231231
"@ember/engine/lib/engine-parent.js": "ember-source/@ember/engine/lib/engine-parent.js",
232232
"@ember/engine/lib/strict-resolver.js": "ember-source/@ember/engine/lib/strict-resolver.js",
233-
"@ember/engine/lib/strict-resolver/string.js": "ember-source/@ember/engine/lib/strict-resolver/string.js",
234233
"@ember/engine/parent.js": "ember-source/@ember/engine/parent.js",
235234
"@ember/enumerable/index.js": "ember-source/@ember/enumerable/index.js",
236235
"@ember/enumerable/mutable.js": "ember-source/@ember/enumerable/mutable.js",

packages/@ember/engine/lib/strict-resolver.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import type { Factory, Resolver } from '@ember/owner';
2-
import { dasherize } from './strict-resolver/string';
32

43
export class StrictResolver implements Resolver {
54
// Ember's router uses this flag to decide whether to auto-generate
@@ -130,6 +129,12 @@ export class StrictResolver implements Resolver {
130129

131130
const fileExtension = /\.\w{1,4}$/;
132131
const leadingDotSlash = /^\.\//;
132+
const camelCaseBoundary = /([a-z\d])([A-Z])/g;
133+
const spacesAndUnderscores = /[ _]/g;
134+
135+
function dasherize(str: string): string {
136+
return str.replace(camelCaseBoundary, '$1_$2').toLowerCase().replace(spacesAndUnderscores, '-');
137+
}
133138

134139
type Result =
135140
| {

packages/@ember/engine/lib/strict-resolver/string.js

Lines changed: 0 additions & 9 deletions
This file was deleted.

packages/@ember/engine/tests/resolver/dasherize_test.js

Lines changed: 0 additions & 36 deletions
This file was deleted.

0 commit comments

Comments
 (0)