Skip to content

Commit a54e687

Browse files
NullVoxPopuliclaude
andcommitted
Drop strictResolver from v2AppScenarios; keep dedicated strict scenario
CI revealed that basic-test.ts includes a route template (`templates/ example-gjs-route.gjs`) that exports a `.gjs` Component class — a v2 convention that works under embroiderVite (via compat-modules) but doesn't render with the strict resolver: owner.lookup('template: example-gjs-route') hands back the Component and rendering fails to produce [data-test=\"model-field\"], so the acceptance test fails. That's a real gap worth fixing, but it belongs in a separate PR that can focus on template-as-component lookup under the strict resolver. For now, drop the v2AppScenarios variant and leave the strictResolver function available via strictAppScenarios (used by the dedicated strict-resolver-test.ts / strict-resolver-substates-test.ts). Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
1 parent a9cfe43 commit a54e687

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

smoke-tests/scenarios/scenarios.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ export const v2AppScenarios = Scenarios.fromProject(() =>
6262
})
6363
).expand({
6464
embroiderVite,
65-
strictResolver,
6665
});
6766

6867
export const strictAppScenarios = Scenarios.fromProject(() =>

0 commit comments

Comments
 (0)