Skip to content

Update ember-estree#206

Merged
NullVoxPopuli merged 1 commit intomainfrom
update-estree
Apr 28, 2026
Merged

Update ember-estree#206
NullVoxPopuli merged 1 commit intomainfrom
update-estree

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

🏎️ Benchmark Comparison

Benchmark Control (p50) Experiment (p50) Δ
gts small 1189.60 ms 1207.08 ms +1.5%
gts medium 2088.62 ms 2105.46 ms +0.8%
gts large 975.23 ms 971.36 ms -0.4%
gjs small 1010.97 ms 1010.81 ms -0.0%
gjs medium 1792.90 ms 1808.61 ms +0.9%
🔴 gjs large 775.91 ms 829.62 ms +6.9%
hbs small 138.38 ms 136.38 ms -1.4%
🟠 hbs medium 922.94 ms 941.92 ms +2.1%
hbs large 938.37 ms 944.99 ms +0.7%

🟢 faster · 🔴 slower · 🟠 slightly slower · ⚪ within 2%

Full mitata output
clk: ~3.37 GHz
cpu: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
runtime: node 24.14.1 (x64-linux)

benchmark                   avg (min … max) p75 / p99    (min … top 1%)
------------------------------------------- -------------------------------
gts small (control)             1.24 s/iter    1.30 s        █             
                          (1.09 s … 1.44 s)    1.38 s ▅  ▅▅ ▅█▅ ▅   ▅ ▅   ▅
                    (143.63 mb … 191.76 mb) 152.84 mb █▁▁██▁███▁█▁▁▁█▁█▁▁▁█

gts small (experiment)          1.22 s/iter    1.24 s      █               
                          (1.08 s … 1.44 s)    1.29 s ▅    █  ▅▅  ▅▅ ▅▅  ▅▅
                    (146.06 mb … 187.19 mb) 155.45 mb █▁▁▁▁█▁▁██▁▁██▁██▁▁██

                             ┌                                            ┐
                               ╷      ┌─────────────┬────────┐            ╷
         gts small (control)   ├──────┤             │        ├────────────┤
                               ╵      └─────────────┴────────┘            ╵
                             ╷       ┌───────────┬───┐      ╷
      gts small (experiment) ├───────┤           │   ├──────┤
                             ╵       └───────────┴───┘      ╵
                             └                                            ┘
                             1.08 s              1.23 s              1.38 s

summary
  gts small (experiment)
   1.02x faster than gts small (control)

------------------------------------------- -------------------------------
gts medium (control)            2.14 s/iter    2.18 s      █               
                          (2.03 s … 2.45 s)    2.20 s      █               
                    (318.52 mb … 338.53 mb) 327.64 mb █▁█▁▁███▁▁▁▁█▁▁▁▁█▁██

gts medium (experiment)         2.13 s/iter    2.16 s █                    
                          (1.99 s … 2.44 s)    2.18 s █    ▅    ▅▅▅▅   ▅▅▅▅
                    (296.90 mb … 349.42 mb) 328.55 mb █▁▁▁▁█▁▁▁▁████▁▁▁████

                             ┌                                            ┐
                                      ╷        ┌────────────┬────────┐    ╷
        gts medium (control)          ├────────┤            │        ├────┤
                                      ╵        └────────────┴────────┘    ╵
                             ╷          ┌────────────────┬───────┐  ╷
     gts medium (experiment) ├──────────┤                │       ├──┤
                             ╵          └────────────────┴───────┘  ╵
                             └                                            ┘
                             1.99 s              2.10 s              2.20 s

summary
  gts medium (experiment)
   1.01x faster than gts medium (control)

------------------------------------------- -------------------------------
gts large (control)             1.01 s/iter    1.03 s         █      █     
                       (919.73 ms … 1.29 s)    1.06 s ▅▅▅▅ ▅  █     ▅█    ▅
                    (124.71 mb … 176.31 mb) 159.38 mb ████▁█▁▁█▁▁▁▁▁██▁▁▁▁█

gts large (experiment)          1.01 s/iter    1.03 s              █       
                       (921.71 ms … 1.26 s)    1.08 s  █  █        █       
                    (132.93 mb … 187.43 mb) 157.47 mb ██▁▁█▁█▁▁▁▁▁▁█▁▁▁█▁▁█

                             ┌                                            ┐
                             ╷   ┌───────────────────┬─────┐         ╷
         gts large (control) ├───┤                   │     ├─────────┤
                             ╵   └───────────────────┴─────┘         ╵
                              ╷ ┌──────────────────────┬───┐              ╷
      gts large (experiment)  ├─┤                      │   ├──────────────┤
                              ╵ └──────────────────────┴───┘              ╵
                             └                                            ┘
                             919.73 ms           999.31 ms           1.08 s

summary
  gts large (control)
   1.01x faster than gts large (experiment)

------------------------------------------- -------------------------------
gjs small (control)             1.04 s/iter    1.07 s █                    
                       (944.49 ms … 1.25 s)    1.10 s █▅    ▅▅▅    ▅▅ ▅  ▅▅
                    (102.78 mb … 152.60 mb) 134.59 mb ██▁▁▁▁███▁▁▁▁██▁█▁▁██

gjs small (experiment)          1.05 s/iter    1.09 s                █     
                       (927.87 ms … 1.25 s)    1.15 s ▅  ▅▅▅ ▅▅    ▅▅█    ▅
                    (112.93 mb … 155.36 mb) 148.88 mb █▁▁███▁██▁▁▁▁███▁▁▁▁█

                             ┌                                            ┐
                                ╷ ┌─────────────────┬──────┐    ╷
         gjs small (control)    ├─┤                 │      ├────┤
                                ╵ └─────────────────┴──────┘    ╵
                             ╷        ┌───────────────┬───────┐           ╷
      gjs small (experiment) ├────────┤               │       ├───────────┤
                             ╵        └───────────────┴───────┘           ╵
                             └                                            ┘
                             927.87 ms            1.04 s             1.15 s

summary
  gjs small (control)
   1.01x faster than gjs small (experiment)

------------------------------------------- -------------------------------
gjs medium (control)            1.82 s/iter    1.85 s █   ██ ██ ██ ███    █
                          (1.67 s … 2.08 s)    1.92 s █   ██ ██ ██ ███    █
                    (259.06 mb … 306.38 mb) 285.13 mb █▁▁▁██▁██▁██▁███▁▁▁▁█

gjs medium (experiment)         1.84 s/iter    1.86 s  █    █  █           
                          (1.71 s … 2.12 s)    1.98 s ▅█    █▅ █ ▅ ▅      ▅
                    (269.81 mb … 279.71 mb) 272.61 mb ██▁▁▁▁██▁█▁█▁█▁▁▁▁▁▁█

                             ┌                                            ┐
                             ╷         ┌──────────┬───┐          ╷
        gjs medium (control) ├─────────┤          │   ├──────────┤
                             ╵         └──────────┴───┘          ╵
                                  ╷ ┌────────────────┬───┐                ╷
     gjs medium (experiment)      ├─┤                │   ├────────────────┤
                                  ╵ └────────────────┴───┘                ╵
                             └                                            ┘
                             1.67 s              1.83 s              1.98 s

summary
  gjs medium (control)
   1.01x faster than gjs medium (experiment)

------------------------------------------- -------------------------------
gjs large (control)          823.57 ms/iter 863.03 ms   █                  
                       (745.84 ms … 1.03 s) 906.04 ms ▅▅█▅▅▅        ▅▅▅   ▅
                    (100.38 mb … 151.29 mb) 140.44 mb ██████▁▁▁▁▁▁▁▁███▁▁▁█

gjs large (experiment)       851.33 ms/iter 898.91 ms █                    
                       (755.46 ms … 1.13 s) 947.15 ms █              ▅     
                    (109.23 mb … 160.21 mb) 130.66 mb █▁▇▁▁▁▁▁▇▁▇▇▁▁▁█▁▁▁▁▇

                             ┌                                            ┐
                             ╷  ┌─────────────┬────────┐         ╷
         gjs large (control) ├──┤             │        ├─────────┤
                             ╵  └─────────────┴────────┘         ╵
                               ╷┌────────────────────┬─────────┐          ╷
      gjs large (experiment)   ├┤                    │         ├──────────┤
                               ╵└────────────────────┴─────────┘          ╵
                             └                                            ┘
                             745.84 ms         846.49 ms          947.15 ms

summary
  gjs large (control)
   1.03x faster than gjs large (experiment)

------------------------------------------- -------------------------------
hbs small (control)          148.05 ms/iter 151.92 ms        █             
                    (108.00 ms … 236.77 ms) 170.36 ms ▅     ▅█ ▅▅▅ ▅▅  ▅  ▅
                    ( 24.43 mb …  67.39 mb)  32.47 mb █▁▁▁▁▁██▁███▁██▁▁█▁▁█

hbs small (experiment)       148.47 ms/iter 150.83 ms █████ ██  █  █   █  █
                    (125.48 ms … 239.68 ms) 164.21 ms █████ ██  █  █   █  █
                    ( 25.91 mb …  69.38 mb)  30.60 mb █████▁██▁▁█▁▁█▁▁▁█▁▁█

                             ┌                                            ┐
                             ╷              ┌─────────────┬──┐            ╷
         hbs small (control) ├──────────────┤             │  ├────────────┤
                             ╵              └─────────────┴──┘            ╵
                                          ╷ ┌─────────────┬─┐         ╷
      hbs small (experiment)              ├─┤             │ ├─────────┤
                                          ╵ └─────────────┴─┘         ╵
                             └                                            ┘
                             108.00 ms         139.18 ms          170.36 ms

summary
  hbs small (control)
   1x faster than hbs small (experiment)

------------------------------------------- -------------------------------
hbs medium (control)         951.80 ms/iter 965.71 ms             █        
                       (887.41 ms … 1.12 s)    1.01 s █           █        
                    (145.33 mb … 199.06 mb) 185.76 mb █▁███▁█▁▁▁▁▁█▁▁▁█▁▁▁█

hbs medium (experiment)      935.49 ms/iter 948.67 ms  █              █   █
                       (881.37 ms … 1.10 s) 956.80 ms ▅█▅▅            █▅▅ █
                    (167.23 mb … 218.69 mb) 175.18 mb ████▁▁▁▁▁▁▁▁▁▁▁▁███▁█

                             ┌                                            ┐
                               ╷   ┌─────────────────┬────┐               ╷
        hbs medium (control)   ├───┤                 │    ├───────────────┤
                               ╵   └─────────────────┴────┘               ╵
                             ╷┌────────────────┬────┐  ╷
     hbs medium (experiment) ├┤                │    ├──┤
                             ╵└────────────────┴────┘  ╵
                             └                                            ┘
                             881.37 ms           947.22 ms           1.01 s

summary
  hbs medium (experiment)
   1.02x faster than hbs medium (control)

------------------------------------------- -------------------------------
hbs large (control)          966.08 ms/iter 990.66 ms     █                
                       (903.97 ms … 1.12 s) 998.51 ms     █           █    
                    (134.47 mb … 188.40 mb) 159.36 mb █▁▁██▁▁█▁▁▁▁▁▁▁▁█▁███

hbs large (experiment)       980.45 ms/iter    1.00 s   █                  
                       (921.00 ms … 1.15 s)    1.03 s   █            ▅     
                    (151.67 mb … 156.40 mb) 153.31 mb ▇▁█▁▇▁▁▁▁▇▁▁▁▁▁█▁▁▁▇▇

                             ┌                                            ┐
                             ╷      ┌──────────────┬────────┐  ╷
         hbs large (control) ├──────┤              │        ├──┤
                             ╵      └──────────────┴────────┘  ╵
                                   ╷   ┌─────────────────┬───────┐        ╷
      hbs large (experiment)       ├───┤                 │       ├────────┤
                                   ╵   └─────────────────┴───────┘        ╵
                             └                                            ┘
                             903.97 ms           966.41 ms           1.03 s

summary
  hbs large (control)
   1.01x faster than hbs large (experiment)

@NullVoxPopuli NullVoxPopuli merged commit a07c777 into main Apr 28, 2026
36 checks passed
@NullVoxPopuli NullVoxPopuli deleted the update-estree branch April 28, 2026 03:05
@github-actions github-actions Bot mentioned this pull request Apr 28, 2026
@NullVoxPopuli NullVoxPopuli added bug Something isn't working and removed internal labels Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant