Skip to content

Extract to ember-estree #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NullVoxPopuli merged 35 commits into from
Mar 19, 2026
Merged

Extract to ember-estree #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
65ca6d4
Extract to ember-estree
NullVoxPopuli Mar 18, 2026
c1d1379
Use git reference
NullVoxPopuli Mar 18, 2026
8ebccda
Use ember-estree minimal API, fix template positions and parent refs
NullVoxPopuli Mar 18, 2026
c2cee1c
Update lockfile for ember-estree git reference
NullVoxPopuli Mar 18, 2026
af42b50
Fix block param positions, guard null comments, update snapshots
NullVoxPopuli Mar 18, 2026
dd87cac
Fix corrupted files from git checkout
NullVoxPopuli Mar 18, 2026
795811e
Fix content range: pass inner content without <template> tags
NullVoxPopuli Mar 18, 2026
791358c
Fix ESLint autofix: clean stale node props, add template tag tokens
NullVoxPopuli Mar 18, 2026
3b6c70a
Patch eslint-plugin-ember test for GlimmerBlockParam type rename
NullVoxPopuli Mar 18, 2026
fa705c4
Fix eslint-plugin-ember patch: use Node fs instead of sed
NullVoxPopuli Mar 18, 2026
c78c201
Point eslint-plugin-ember test at fork with GlimmerBlockParam fix
NullVoxPopuli Mar 18, 2026
84645a0
Fix prettier formatting in eslint-plugin-ember test script
NullVoxPopuli Mar 18, 2026
71f8bc2
WIP: Use toTree with custom parser, drop preprocessGlimmerTemplates
NullVoxPopuli Mar 18, 2026
b3752e7
Consolidate into toTree: drop transformForLint from pipeline, fix perf
NullVoxPopuli Mar 18, 2026
9cf74c4
Visitor-based scope registration, drop toTSPlaceholderJS, use toPlace…
NullVoxPopuli Mar 18, 2026
7d32a76
Update ember-estree ref for perf optimizations
NullVoxPopuli Mar 18, 2026
de9c6b5
Update ember-estree ref — benchmark at parity with baseline
NullVoxPopuli Mar 18, 2026
d618850
Use glimmerVisitorKeys const, inline placeholder logic, drop toPlaceh…
NullVoxPopuli Mar 18, 2026
51f2996
Tighten test assertions: expect(i).toBe(nodes.length)
NullVoxPopuli Mar 19, 2026
7e6a6d0
Update ember-estree ref after cleanup
NullVoxPopuli Mar 19, 2026
4407fd7
Merge glimmerVisitorKeys in parseForESLint, not toTree
NullVoxPopuli Mar 19, 2026
23fe388
Remove visitorKeys merge — toTree handles it now
NullVoxPopuli Mar 19, 2026
31db7da
All paths use visitors: eliminate registerGlimmerScopes second pass
NullVoxPopuli Mar 19, 2026
41c26c7
Add @babel/eslint-parser to experimental-worker test projects
NullVoxPopuli Mar 19, 2026
4b17734
Update ember-estree ref (removed templateRange/codeLines options)
NullVoxPopuli Mar 19, 2026
fd64e47
Simplify parser callbacks to (placeholderJS) => result
NullVoxPopuli Mar 19, 2026
33f731f
Update ember-estree ref (includeParentLinks option, remove removePare…
NullVoxPopuli Mar 19, 2026
f72dfbe
Drop oxc-parser dep: JS path uses ember-estree's default parser
NullVoxPopuli Mar 19, 2026
0a253d8
Fix JS path: skip Glimmer nodes in eslint-scope analysis
NullVoxPopuli Mar 19, 2026
759a667
Update ember-estree ref — plain Glimmer objects, drop esrecurse fallback
NullVoxPopuli Mar 19, 2026
284313b
Defer DocumentLines creation in hbs-parser to error path only
NullVoxPopuli Mar 19, 2026
f7bba38
Use ember-estree ^0.4.1 (published release)
NullVoxPopuli Mar 19, 2026
be4f3c1
Both paths use visitors for single-pass scope registration
NullVoxPopuli Mar 19, 2026
d82c51b
Revert eslint-plugin-ember test script to upstream
NullVoxPopuli Mar 19, 2026
f18b327
Revert "Revert eslint-plugin-ember test script to upstream"
NullVoxPopuli Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@
"test": "vitest run"
},
"dependencies": {
"@babel/eslint-parser": "^7.28.6",
"@glimmer/syntax": ">= 0.92.0",
"@typescript-eslint/tsconfig-utils": "^8.38.0",
"content-tag": "^4.1.0",
"ember-estree": "^0.4.1",
"eslint-scope": "^9.1.1",
"html-tags": "^5.1.0",
"mathml-tag-names": "^4.0.0",
Expand Down Expand Up @@ -64,7 +64,6 @@
"vitest": "^1.2.2"
},
"peerDependencies": {
"@babel/core": "^7.23.6",
"@typescript-eslint/parser": "*"
},
"peerDependenciesMeta": {
Expand Down
Loading
Loading