Skip to content

Answer: --expose-gc is active during benchmarks#178

Closed
Copilot wants to merge 1 commit intonvp/bench-summaryfrom
copilot/sub-pr-177
Closed

Answer: --expose-gc is active during benchmarks#178
Copilot wants to merge 1 commit intonvp/bench-summaryfrom
copilot/sub-pr-177

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 15, 2026

Confirmed that globalThis.gc?.() calls in the benchmark are not no-ops — the bench script passes --expose-gc to Node:

"bench": "node --expose-gc tests/parser.bench.mjs"

So the GC hints before each benchmark group are effective.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] Make it easier to get a summary of the bench results locally Answer: --expose-gc is active during benchmarks Mar 15, 2026
Copilot AI requested a review from NullVoxPopuli March 15, 2026 20:36
@NullVoxPopuli NullVoxPopuli deleted the copilot/sub-pr-177 branch March 15, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants