Convert library to ESM#176
Merged
NullVoxPopuli merged 4 commits intomainfrom Mar 15, 2026
Merged
Conversation
9 tasks
Co-authored-by: NullVoxPopuli <[email protected]>
Copilot
AI
changed the title
[WIP] Convert library to ESM and add publint if necessary
Convert library to ESM
Mar 15, 2026
Contributor
Author
There was a problem hiding this comment.
Done in 28bcd98. lint:package (which calls publint) was already wired into pnpm lint via the npm:lint:*(!fix) glob — I updated the script to call publint directly rather than going through pnpm publint.
Co-authored-by: NullVoxPopuli <[email protected]>
NullVoxPopuli
approved these changes
Mar 15, 2026
Contributor
🏎️ Benchmark Comparison
Full mitata output |
Member
|
NOTE: benchmark is wildly unstable on CI -- for good results, you'll want to run locally |
Copilot AI
added a commit
that referenced
this pull request
Mar 15, 2026
Co-authored-by: NullVoxPopuli <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"type": "module"to package.json.eslintrc.js→.eslintrc.cjs(usesmodule.exports).prettierrc.js→.prettierrc.cjs(usesmodule.exports).eslintrc.cjsto usesourceType: 'module'by defaultsrc/utils/document.jsto ESMsrc/preprocessor/noop.jsto ESMsrc/parser/transforms.jsto ESMsrc/parser/ts-patch.jsto ESMsrc/parser/hbs-parser.jsto ESMsrc/parser/gjs-gts-parser.jsto ESMlint:packagecallspublintdirectly (wired intopnpm lintvianpm:lint:*(!fix)glob)pnpm lintruns both eslint and publint cleanly🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.