-
Notifications
You must be signed in to change notification settings - Fork 39
Dropped Node 18 support #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ijlee2
wants to merge
9
commits into
ember-template-lint:master
Choose a base branch
from
ijlee2:update-dependencies-part-1c
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dropped Node 18 support #1009
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
583f5b6
chore: Standardized scripts
ijlee2 659ff6e
chore: Updated lint dependencies
ijlee2 afad638
chore: Ran lint:js:fix
ijlee2 82623f0
chore: Ignored lint errors
ijlee2 a0ea4fe
chore: Ran format
ijlee2 44902c1
chore: Updated jest to v30
ijlee2 4e3e123
chore: Added lockfile
ijlee2 81fb86d
chore: Standardized distribution
ijlee2 858b7ef
breaking: Dropped Node 18 support
ijlee2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,11 @@ | ||
| # See https://help.github.com/ignore-files/ for more about ignoring files. | ||
| # compiled output | ||
| dist/ | ||
|
|
||
| # dependencies | ||
| /node_modules | ||
| node_modules/ | ||
|
|
||
| # misc | ||
| npm-debug.log* | ||
| yarn-error.log | ||
| /.vscode | ||
| /.log/ | ||
|
|
||
| # compiled output | ||
| /lib | ||
| .DS_Store | ||
| .env* | ||
| .eslintcache | ||
| pnpm-debug.log* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| auto-install-peers=false | ||
| public-hoist-pattern[]=*eslint* | ||
| public-hoist-pattern[]=*prettier* | ||
| resolve-peers-from-workspace-root=false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 20.19.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # compiled output | ||
| /dist/ | ||
|
|
||
| # misc | ||
| pnpm-lock.yaml | ||
| !.* | ||
| .*/ | ||
|
|
||
| # specific to this package | ||
| CHANGELOG.md | ||
| README.md |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| import babelEslintParser from '@babel/eslint-parser'; | ||
| import eslint from '@eslint/js'; | ||
| import eslintConfigPrettier from 'eslint-config-prettier'; | ||
| import eslintPluginImportX from 'eslint-plugin-import-x'; | ||
| import eslintPluginN from 'eslint-plugin-n'; | ||
| import globals from 'globals'; | ||
| import tseslint from 'typescript-eslint'; | ||
|
|
||
| const parserOptionsJs = { | ||
| ecmaFeatures: { | ||
| modules: true, | ||
| }, | ||
| ecmaVersion: 'latest', | ||
| requireConfigFile: false, | ||
| }; | ||
|
|
||
| const parserOptionsTs = { | ||
| projectService: true, | ||
| }; | ||
|
|
||
| export default tseslint.config( | ||
| { | ||
| ignores: ['dist/', 'node_modules/', '.*/'], | ||
| }, | ||
| { | ||
| linterOptions: { | ||
| reportUnusedDisableDirectives: 'error', | ||
| }, | ||
| }, | ||
|
|
||
| eslint.configs.recommended, | ||
| eslintPluginImportX.flatConfigs.recommended, | ||
| eslintConfigPrettier, | ||
| { | ||
| rules: { | ||
| curly: 'error', | ||
| 'import-x/no-duplicates': 'error', | ||
| 'import-x/no-unresolved': 'off', | ||
| }, | ||
| }, | ||
|
|
||
| // JavaScript files | ||
| { | ||
| files: ['**/*.js'], | ||
| languageOptions: { | ||
| parser: babelEslintParser, | ||
| parserOptions: parserOptionsJs, | ||
| }, | ||
| }, | ||
|
|
||
| // TypeScript files | ||
| { | ||
| extends: [ | ||
| tseslint.configs.recommendedTypeChecked, | ||
| eslintPluginImportX.flatConfigs.typescript, | ||
| ], | ||
| files: ['**/*.ts'], | ||
| languageOptions: { | ||
| parserOptions: parserOptionsTs, | ||
| }, | ||
| rules: { | ||
| '@typescript-eslint/array-type': 'error', | ||
| '@typescript-eslint/consistent-type-imports': 'error', | ||
| '@typescript-eslint/method-signature-style': ['error', 'property'], | ||
| '@typescript-eslint/no-explicit-any': 'off', | ||
| '@typescript-eslint/no-import-type-side-effects': 'error', | ||
| '@typescript-eslint/no-unsafe-argument': 'off', | ||
| '@typescript-eslint/no-unsafe-assignment': 'off', | ||
| '@typescript-eslint/no-unsafe-call': 'off', | ||
| '@typescript-eslint/no-unsafe-member-access': 'off', | ||
| '@typescript-eslint/no-unsafe-return': 'off', | ||
| 'import-x/no-named-as-default-member': 'off', | ||
| 'prefer-const': 'off', | ||
| }, | ||
| settings: { | ||
| 'import-x/resolver': { | ||
| node: true, | ||
| typescript: true, | ||
| }, | ||
| }, | ||
| }, | ||
|
|
||
| // Configuration files | ||
| { | ||
| ...eslintPluginN.configs['flat/recommended-script'], | ||
| files: ['**/*.cjs', 'jest.config.js'], | ||
| languageOptions: { | ||
| ecmaVersion: 'latest', | ||
| globals: globals.node, | ||
| sourceType: 'script', | ||
| }, | ||
| plugins: { | ||
| n: eslintPluginN, | ||
| }, | ||
| }, | ||
| { | ||
| ...eslintPluginN.configs['flat/recommended-module'], | ||
| files: ['**/*.mjs'], | ||
| languageOptions: { | ||
| ecmaVersion: 'latest', | ||
| globals: globals.node, | ||
| parserOptions: parserOptionsJs, | ||
| sourceType: 'module', | ||
| }, | ||
| plugins: { | ||
| n: eslintPluginN, | ||
| }, | ||
| }, | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| module.exports = { | ||
| preset: 'ts-jest', | ||
| testEnvironment: 'node', | ||
| roots: ['<rootDir>/src/'], | ||
| testEnvironment: 'node', | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,25 +15,27 @@ | |
| "repository": "github:ember-template-lint/ember-template-recast", | ||
| "license": "MIT", | ||
| "author": "Robert Jackson <[email protected]>", | ||
| "main": "lib/index.js", | ||
| "bin": "lib/bin.js", | ||
| "main": "dist/index.js", | ||
| "bin": "dist/bin.js", | ||
| "files": [ | ||
| "lib/", | ||
| "!lib/**/*.test.*" | ||
| "dist/", | ||
| "!dist/**/*.test.*" | ||
| ], | ||
| "scripts": { | ||
| "build": "tsc", | ||
| "lint": "npm-run-all lint:*", | ||
| "lint:files": "eslint .", | ||
| "lint:tsc": "tsc --noEmit", | ||
| "format": "prettier . --cache --write", | ||
| "lint": "concurrently \"pnpm:lint:*(!fix)\" --names \"lint:\"", | ||
| "lint:fix": "concurrently \"pnpm:lint:*:fix\" --names \"fix:\" && pnpm format", | ||
| "lint:format": "prettier . --cache --check", | ||
| "lint:js": "eslint . --cache", | ||
| "lint:js:fix": "eslint . --fix", | ||
| "lint:types": "tsc --noEmit", | ||
| "perf:benchmark": "node scripts/benchmark.mjs", | ||
| "prepare": "tsc", | ||
| "test": "npm-run-all lint test:*", | ||
| "test:jest": "jest" | ||
| "prepare": "pnpm build", | ||
| "test": "jest" | ||
| }, | ||
| "dependencies": { | ||
| "@glimmer/syntax": ">= 0.84.3", | ||
| "@types/tmp": "^0.2.6", | ||
| "async-promise-queue": "^1.0.5", | ||
| "colors": "^1.4.0", | ||
| "commander": "^8.3.0", | ||
|
|
@@ -44,30 +46,36 @@ | |
| "workerpool": "^6.4.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/jest": "^27.4.0", | ||
| "@types/workerpool": "^6.1.1", | ||
| "@babel/core": "^7.29.0", | ||
| "@babel/eslint-parser": "^7.28.6", | ||
| "@eslint/js": "^9.39.4", | ||
| "@glimmer/reference": "^0.84.3", | ||
| "@glimmer/validator": "^0.84.3", | ||
| "@typescript-eslint/eslint-plugin": "^5.9.1", | ||
| "@typescript-eslint/parser": "^5.9.1", | ||
| "@types/jest": "^30.0.0", | ||
| "@types/node": "^20.19.37", | ||
| "@types/tmp": "^0.2.6", | ||
| "@types/workerpool": "^6.1.1", | ||
| "benchmark": "^2.1.4", | ||
| "broccoli-test-helper": "^2.0.0", | ||
| "eslint": "^8.36.0", | ||
| "eslint-config-prettier": "^8.3.0", | ||
| "eslint-plugin-node": "^11.1.0", | ||
| "eslint-plugin-prettier": "^4.0.0", | ||
| "concurrently": "^9.2.1", | ||
| "eslint": "^9.39.4", | ||
| "eslint-config-prettier": "^10.1.8", | ||
| "eslint-import-resolver-typescript": "^4.4.4", | ||
| "eslint-plugin-import-x": "^4.16.2", | ||
| "eslint-plugin-n": "^17.24.0", | ||
| "execa": "^5.1.1", | ||
| "jest": "^26.6.3", | ||
| "npm-run-all": "^4.1.5", | ||
| "globals": "^17.4.0", | ||
| "jest": "^30.3.0", | ||
| "outdent": "^0.8.0", | ||
| "prettier": "^2.5.1", | ||
| "prettier": "^3.8.1", | ||
| "release-plan": "^0.16.0", | ||
| "ts-jest": "^26.5.6", | ||
| "typescript": "~4.9.5" | ||
| "ts-jest": "^29.4.6", | ||
| "typescript": "^5.9.3", | ||
| "typescript-eslint": "^8.57.0" | ||
| }, | ||
| "packageManager": "pnpm@10.9.0", | ||
| "packageManager": "pnpm@10.32.1", | ||
| "engines": { | ||
| "node": ">= 18.12" | ||
| "node": "20.* || >= 22" | ||
| }, | ||
| "publishConfig": { | ||
| "registry": "https://registry.npmjs.org" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this file <3