Skip to content

update ember-test-helper-api-migration to support more case#47

Open
zhanwang626 wants to merge 2 commits intoember-codemods:masterfrom
zhanwang626:zhanwang/update-test-helper-api-migration
Open

update ember-test-helper-api-migration to support more case#47
zhanwang626 wants to merge 2 commits intoember-codemods:masterfrom
zhanwang626:zhanwang/update-test-helper-api-migration

Conversation

@zhanwang626
Copy link
Copy Markdown

Previous ember-test-helper-api-migration transform does not support the following case:
From

import { click } from '@ember/test-helpers';
import { TestContext } from 'ember-test-helpers';

    /** @type {TestContext['setProperties']} */
    let setProperties;

To

import { click, TestContext } from '@ember/test-helpers';

    /** @type {TestContext['setProperties']} */
    let setProperties;

Because there is no CallExpression contain TestContext, the TestContext specifier would be filtered by https://github.com/ember-codemods/ember-test-helpers-codemod/blob/master/transforms/utils.js#L366

This PR will fix above issue and update the README for this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants