update ember-test-helper-api-migration to support more case#47
Open
zhanwang626 wants to merge 2 commits intoember-codemods:masterfrom
Open
update ember-test-helper-api-migration to support more case#47zhanwang626 wants to merge 2 commits intoember-codemods:masterfrom
zhanwang626 wants to merge 2 commits intoember-codemods:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous
ember-test-helper-api-migrationtransform does not support the following case:From
To
Because there is no
CallExpressioncontainTestContext, theTestContextspecifier would be filtered by https://github.com/ember-codemods/ember-test-helpers-codemod/blob/master/transforms/utils.js#L366This PR will fix above issue and update the README for this repo.