Bump ember-template-recast v3 to v6#27
Open
apellerano-pw wants to merge 1 commit intoember-codemods:masterfrom
Open
Bump ember-template-recast v3 to v6#27apellerano-pw wants to merge 1 commit intoember-codemods:masterfrom
apellerano-pw wants to merge 1 commit intoember-codemods:masterfrom
Conversation
9 tasks
|
I thought it might be useful to others who run into this since the PR isn't merged yet. You can run the codemod from the fork and this branch by doing this: Thanks for this! |
Closed
9 tasks
NullVoxPopuli
previously approved these changes
Aug 5, 2025
Contributor
|
looks like in order to use this upgrade, some other maintenance needs to happen first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 1.2.0 of the codemod is failing to parse render-invoked helpers, e.g.
For conditional modifiers, this syntax must be used. If you omit the extra parenthesis in
{{()}}ember will not compile the template.I tried bumping ember-template-recast from v3 to v6 and it fixed this issue.