Skip to content

BUGFIX: false positive: interactive flow content inside <details>#2713

Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom
johanrd:fix/template-no-nested-interactive-details
Apr 21, 2026
Merged

BUGFIX: false positive: interactive flow content inside <details>#2713
NullVoxPopuli merged 1 commit intoember-cli:masterfrom
johanrd:fix/template-no-nested-interactive-details

Conversation

@johanrd
Copy link
Copy Markdown
Contributor

@johanrd johanrd commented Apr 20, 2026

Narrow fix: <details> stays in the interactive set, so the rule still flags:

  • <details> inside another interactive element (e.g. <button><details/></button>)
  • <summary> when it is not the first non-whitespace child of <details>

Only the case of "interactive element in the disclosed panel (sibling of <summary>)" is exempted — <details>'s own children other than <summary> no longer see <details> as an interactive ancestor.

Upstream [email protected] has the same false positive; fixing here is pragmatic since ember-template-lint is being de-emphasized.

@johanrd johanrd marked this pull request as ready for review April 20, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants