BUGFIX: false positive: interactive flow content inside <details>#2713
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Apr 21, 2026
Merged
Conversation
NullVoxPopuli
approved these changes
Apr 21, 2026
This was referenced Apr 21, 2026
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<details>is "one<summary>element, followed by flow content" — see the spec's own example mixing<input>and<label>as siblings of<summary>.<label>,<input>,<button>,<form>.<summary>inside<details>is spec-conformant and should not be flagged.Narrow fix:
<details>stays in the interactive set, so the rule still flags:<details>inside another interactive element (e.g.<button><details/></button>)<summary>when it is not the first non-whitespace child of<details>Only the case of "interactive element in the disclosed panel (sibling of
<summary>)" is exempted —<details>'s own children other than<summary>no longer see<details>as an interactive ancestor.Upstream
[email protected]has the same false positive; fixing here is pragmatic sinceember-template-lintis being de-emphasized.