Skip to content

Post-merge-review: Fix template-no-nested-landmark: drop port-only section/region #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NullVoxPopuli merged 5 commits into from
Apr 15, 2026
Merged

Post-merge-review: Fix template-no-nested-landmark: drop port-only section/region #2694

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
958884b
Fix template-no-nested-landmark: drop port-only section/region
johanrd Apr 13, 2026
2f96a82
chore: replace 'per upstream' comments with MDN-sourced rationale
johanrd Apr 14, 2026
6d80f65
chore: cite W3C ARIA APG instead of MDN
johanrd Apr 14, 2026
7ac894b
chore: cite MDN region role page instead of W3C APG
johanrd Apr 14, 2026
d553f24
chore: cite HTML-AAM spec for section→region role mapping
johanrd Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/rules/template-no-nested-landmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,10 @@ const LANDMARK_ROLES = new Set([
'form',
'main',
'navigation',
'region',
'search',
]);

const LANDMARK_ELEMENTS = new Set(['header', 'aside', 'footer', 'form', 'main', 'nav', 'section']);
const LANDMARK_ELEMENTS = new Set(['header', 'aside', 'footer', 'form', 'main', 'nav']);

const EQUIVALENT_ROLE = {
aside: 'complementary',
Expand Down
9 changes: 9 additions & 0 deletions tests/lib/rules/template-no-nested-landmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ ruleTester.run('template-no-nested-landmark', rule, {
'<template><div role="banner"><nav></nav></div></template>',
'<template><header><div role="navigation"></div></header></template>',
'<template><div role="banner"><div role="navigation"></div></div></template>',

// `<section>` only gets the `region` landmark role when it has an accessible name
// (aria-label/aria-labelledby/title). Without one it has the generic role — see
// https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/section.
Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/landmark_role

Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Copy link
Copy Markdown
Contributor Author

@johanrd johanrd Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MDN is inconsistent on this — checked the HTML-AAM spec directly: https://www.w3.org/TR/html-aam-1.0/#el-section — "region role if the section element has an accessible name. Otherwise, the generic role."

Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyty

// This rule does not inspect accessible names, so unnamed sections are excluded.
'<template><section><section>Content</section></section></template>',
// `role="region"` is the landmark role a named `<section>` gets. Nesting it is
// excluded for the same reason: the rule cannot verify an accessible name is present.
'<template><div role="region"><div role="region">Content</div></div></template>',
],

invalid: [
Expand Down
Loading