Post-merge-review: Fix template-require-context-role: align aria-hidden scope and report oc with upstream#2686
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Apr 14, 2026
Conversation
… loc with upstream Limit aria-hidden suppression to the immediate parent (port previously walked the full ancestor stack — over-permissive). Report on the role attribute node, not the element, to match upstream.
johanrd
force-pushed
the
day_fix/template-require-context-role
branch
from
10256eb to
4196ef0
Compare
NullVoxPopuli
approved these changes
Apr 14, 2026
This was referenced Apr 14, 2026
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit aria-hidden suppression to the immediate parent (port previously walked the full ancestor stack — over-permissive). Report on the role attribute node, not the element, to match upstream.
Cowritten by claude